Browse Source

use this.boundDrawFn

pull/164/head
t47io 7 years ago
parent
commit
0d5eeccd78
2 changed files with 8 additions and 13 deletions
  1. +1
    -1
      docs/index.html
  2. +7
    -12
      src/js/charts/BaseChart.js

+ 1
- 1
docs/index.html View File

@@ -301,7 +301,7 @@
chart.export();

// Unbind window-resize events
chart.unbindWindowEvents();
chart.destroy();

</code></pre>
</div>


+ 7
- 12
src/js/charts/BaseChart.js View File

@@ -7,8 +7,6 @@ import { getColor, isValidColor } from '../utils/colors';
import { runSMILAnimation } from '../utils/animation';
import { downloadFile, prepareForExport } from '../utils/export';

let BOUND_DRAW_FN;

export default class BaseChart {
constructor(parent, options) {

@@ -89,18 +87,15 @@ export default class BaseChart {
this.height = height - getExtraHeight(this.measures);

// Bind window events
BOUND_DRAW_FN = this.boundDrawFn.bind(this);
window.addEventListener('resize', BOUND_DRAW_FN);
window.addEventListener('orientationchange', this.boundDrawFn.bind(this));
}

boundDrawFn() {
this.draw(true);
this.boundDrawFn = () => this.draw(true);
window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn);
}

unbindWindowEvents() {
window.removeEventListener('resize', BOUND_DRAW_FN);
window.removeEventListener('orientationchange', this.boundDrawFn.bind(this));
destroy() {
// Unbind window events
window.removeEventListener('resize', this.boundDrawFn);
window.removeEventListener('orientationchange', this.boundDrawFn);
}

// Has to be called manually


Loading…
Cancel
Save