Bladeren bron

Merge pull request #238 from frappe/fix-event-listener

fix: destroying event listener on window
tags/1.3.0
Shivam Mishra 5 jaren geleden
committed by GitHub
bovenliggende
commit
317136eec4
Geen bekende sleutel gevonden voor deze handtekening in de database GPG sleutel-ID: 4AEE18F83AFDEB23
2 gewijzigde bestanden met toevoegingen van 7 en 13 verwijderingen
  1. +1
    -1
      docs/index.html
  2. +6
    -12
      src/js/charts/BaseChart.js

+ 1
- 1
docs/index.html Bestand weergeven

@@ -261,7 +261,7 @@ redirect_to: "https://frappe.io/charts"
chart.export();

// Unbind window-resize events
chart.unbindWindowEvents();
chart.destroy();

</code></pre>
</section>


+ 6
- 12
src/js/charts/BaseChart.js Bestand weergeven

@@ -7,8 +7,6 @@ import { getColor, isValidColor } from '../utils/colors';
import { runSMILAnimation } from '../utils/animation';
import { downloadFile, prepareForExport } from '../utils/export';

let BOUND_DRAW_FN;

export default class BaseChart {
constructor(parent, options) {

@@ -90,18 +88,14 @@ export default class BaseChart {
this.height = height - getExtraHeight(this.measures);

// Bind window events
BOUND_DRAW_FN = this.boundDrawFn.bind(this);
window.addEventListener('resize', BOUND_DRAW_FN);
window.addEventListener('orientationchange', this.boundDrawFn.bind(this));
}

boundDrawFn() {
this.draw(true);
this.boundDrawFn = () => this.draw(true);
window.addEventListener('resize', this.boundDrawFn);
window.addEventListener('orientationchange', this.boundDrawFn);
}

unbindWindowEvents() {
window.removeEventListener('resize', BOUND_DRAW_FN);
window.removeEventListener('orientationchange', this.boundDrawFn.bind(this));
destroy() {
window.removeEventListener('resize', this.boundDrawFn);
window.removeEventListener('orientationchange', this.boundDrawFn);
}

// Has to be called manually


Laden…
Annuleren
Opslaan