From 846a21ae6a3cc57e68c714b38e338d01eea80f81 Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Tue, 28 Jul 2020 15:46:37 +0530
Subject: [PATCH] feat: remove depth for percentage chart

---
 src/js/charts/PercentageChart.js | 4 +---
 src/js/utils/constants.js        | 3 +--
 src/js/utils/draw.js             | 3 +--
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/js/charts/PercentageChart.js b/src/js/charts/PercentageChart.js
index cd91469..d673ba0 100644
--- a/src/js/charts/PercentageChart.js
+++ b/src/js/charts/PercentageChart.js
@@ -1,7 +1,7 @@
 import AggregationChart from './AggregationChart';
 import { getOffset } from '../utils/dom';
 import { getComponent } from '../objects/ChartComponents';
-import { PERCENTAGE_BAR_DEFAULT_HEIGHT, PERCENTAGE_BAR_DEFAULT_DEPTH } from '../utils/constants';
+import { PERCENTAGE_BAR_DEFAULT_HEIGHT } from '../utils/constants';
 
 export default class PercentageChart extends AggregationChart {
 	constructor(parent, args) {
@@ -16,7 +16,6 @@ export default class PercentageChart extends AggregationChart {
 
 		let b = this.barOptions;
 		b.height = b.height || PERCENTAGE_BAR_DEFAULT_HEIGHT;
-		b.depth = b.depth || PERCENTAGE_BAR_DEFAULT_DEPTH;
 
 		m.paddings.right = 30;
 		m.legendHeight = 60;
@@ -31,7 +30,6 @@ export default class PercentageChart extends AggregationChart {
 				'percentageBars',
 				{
 					barHeight: this.barOptions.height,
-					barDepth: this.barOptions.depth,
 				},
 				function() {
 					return {
diff --git a/src/js/utils/constants.js b/src/js/utils/constants.js
index 9490e30..206519f 100644
--- a/src/js/utils/constants.js
+++ b/src/js/utils/constants.js
@@ -73,8 +73,7 @@ export const MIN_BAR_PERCENT_HEIGHT = 0.00;
 export const LINE_CHART_DOT_SIZE = 4;
 export const DOT_OVERLAY_SIZE_INCR = 4;
 
-export const PERCENTAGE_BAR_DEFAULT_HEIGHT = 20;
-export const PERCENTAGE_BAR_DEFAULT_DEPTH = 2;
+export const PERCENTAGE_BAR_DEFAULT_HEIGHT = 16;
 
 // Fixed 5-color theme,
 // More colors are difficult to parse visually
diff --git a/src/js/utils/draw.js b/src/js/utils/draw.js
index 5a5121b..4122386 100644
--- a/src/js/utils/draw.js
+++ b/src/js/utils/draw.js
@@ -1,7 +1,6 @@
 import { getBarHeightAndYAttr, truncateString, shortenLargeNumber, getSplineCurvePointsStr } from './draw-utils';
 import { getStringWidth, isValidNumber } from './helpers';
-import { DOT_OVERLAY_SIZE_INCR, PERCENTAGE_BAR_DEFAULT_DEPTH } from './constants';
-import { lightenDarkenColor } from './colors';
+import { DOT_OVERLAY_SIZE_INCR } from './constants';
 
 export const AXIS_TICK_LENGTH = 6;
 const LABEL_MARGIN = 4;