From 0176e202fa245d89deea51072bdf3664ce26697d Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Tue, 24 Oct 2017 18:40:17 +0530 Subject: [PATCH] fix codacy --- frappe/build.js | 5 +++-- frappe/desk/doctype/calendar_view/calendar_view.js | 4 ++-- frappe/desk/doctype/calendar_view/calendar_view.py | 1 - frappe/public/js/frappe/list/list_renderer.js | 1 - frappe/public/js/frappe/list/list_sidebar.js | 3 +-- frappe/public/js/frappe/views/calendar/calendar.js | 4 ++-- 6 files changed, 8 insertions(+), 10 deletions(-) diff --git a/frappe/build.js b/frappe/build.js index 32bffe750b..9323860906 100644 --- a/frappe/build.js +++ b/frappe/build.js @@ -60,11 +60,12 @@ function watch() { io.emit('reload_css', filename); } }); - watch_js(function (filename) { + watch_js(//function (filename) { // if(socket_connection) { // io.emit('reload_js', filename); // } - }); + //} + ); watch_build_json(); }); diff --git a/frappe/desk/doctype/calendar_view/calendar_view.js b/frappe/desk/doctype/calendar_view/calendar_view.js index e93473f61e..a58a9555db 100644 --- a/frappe/desk/doctype/calendar_view/calendar_view.js +++ b/frappe/desk/doctype/calendar_view/calendar_view.js @@ -8,7 +8,7 @@ frappe.ui.form.on('Calendar View', { refresh: function(frm) { if (!frm.is_new()) { frm.add_custom_button(__('Show Calendar'), - () => frappe.set_route('List', frm.doc.reference_doctype, 'Calendar', frm.doc.name)) + () => frappe.set_route('List', frm.doc.reference_doctype, 'Calendar', frm.doc.name)); } }, reference_doctype: function(frm) { @@ -24,7 +24,7 @@ frappe.ui.form.on('Calendar View', { const date_options = meta.fields.filter( df => ['Date', 'Datetime'].includes(df.fieldtype) - ).map(df => df.fieldname) + ).map(df => df.fieldname); frm.set_df_property('subject_field', 'options', subject_options); frm.set_df_property('start_date_field', 'options', date_options); diff --git a/frappe/desk/doctype/calendar_view/calendar_view.py b/frappe/desk/doctype/calendar_view/calendar_view.py index 6bb9f6e90a..ae8ab1eb46 100644 --- a/frappe/desk/doctype/calendar_view/calendar_view.py +++ b/frappe/desk/doctype/calendar_view/calendar_view.py @@ -3,7 +3,6 @@ # For license information, please see license.txt from __future__ import unicode_literals -import frappe from frappe.model.document import Document class CalendarView(Document): diff --git a/frappe/public/js/frappe/list/list_renderer.js b/frappe/public/js/frappe/list/list_renderer.js index 446fadbdd7..7a831b6606 100644 --- a/frappe/public/js/frappe/list/list_renderer.js +++ b/frappe/public/js/frappe/list/list_renderer.js @@ -359,7 +359,6 @@ frappe.views.ListRenderer = Class.extend({ }, render_count: function(current_count) { - console.log(this) const $header_right = this.list_view.list_header.find('.list-item__content--activity'); frappe.call({ diff --git a/frappe/public/js/frappe/list/list_sidebar.js b/frappe/public/js/frappe/list/list_sidebar.js index 3cdd21a227..7c6ba5c14d 100644 --- a/frappe/public/js/frappe/list/list_sidebar.js +++ b/frappe/public/js/frappe/list/list_sidebar.js @@ -279,8 +279,7 @@ frappe.views.ListSidebar = Class.extend({ filters: { reference_doctype: doctype } - }) - .then(result => { + }).then(result => { if (!result) return; const calendar_views = result; const $link_calendar = this.sidebar.find('.list-link[data-view="Calendar"]'); diff --git a/frappe/public/js/frappe/views/calendar/calendar.js b/frappe/public/js/frappe/views/calendar/calendar.js index 3845404907..45c15990bf 100644 --- a/frappe/public/js/frappe/views/calendar/calendar.js +++ b/frappe/public/js/frappe/views/calendar/calendar.js @@ -74,11 +74,11 @@ frappe.views.CalendarView = frappe.views.ListRenderer.extend({ return new Promise(resolve => { if (calendar_view === 'Default') { - Object.assign(options, frappe.views.calendar[this.doctype]) + Object.assign(options, frappe.views.calendar[this.doctype]); resolve(options); } else { - frappe.model.with_doc('Calendar View', calendar_view, (name, r) => { + frappe.model.with_doc('Calendar View', calendar_view, () => { const doc = frappe.get_doc('Calendar View', calendar_view); Object.assign(options, { field_map: {