diff --git a/frappe/core/page/permission_manager/permission_manager.js b/frappe/core/page/permission_manager/permission_manager.js index 020db1d16b..b0dc64de97 100644 --- a/frappe/core/page/permission_manager/permission_manager.js +++ b/frappe/core/page/permission_manager/permission_manager.js @@ -46,13 +46,13 @@ frappe.PermissionEngine = Class.extend({ var me = this; this.doctype_select = this.wrapper.page.add_select(__("Document Types"), - [{value: "", label: __("Select Document Type")+"..."}].concat(this.options.doctypes.sort())) + [{value: "", label: __("Select Document Type")+"..."}].concat(this.options.doctypes)) .change(function() { frappe.set_route("permission-manager", $(this).val()); }); this.role_select = this.wrapper.page.add_select(__("Roles"), - [__("Select Role")+"..."].concat(this.options.roles.sort())) + [__("Select Role")+"..."].concat(this.options.roles)) .change(function() { me.refresh(); }); diff --git a/frappe/core/page/permission_manager/permission_manager.py b/frappe/core/page/permission_manager/permission_manager.py index ae3a3971e6..996c7b23d2 100644 --- a/frappe/core/page/permission_manager/permission_manager.py +++ b/frappe/core/page/permission_manager/permission_manager.py @@ -35,9 +35,12 @@ def get_roles_and_doctypes(): "restrict_to_domain": ("in", active_domains) }, fields=["name"]) + doctypes_list = [ {"label":_(d.get("name")), "value":d.get("name")} for d in doctypes] + roles_list = [ {"label":_(d.get("name")), "value":d.get("name")} for d in roles] + return { - "doctypes": [d.get("name") for d in doctypes], - "roles": [d.get("name") for d in roles] + "doctypes": sorted(doctypes_list, key=lambda d: d['label']), + "roles": sorted(roles_list, key=lambda d: d['label']) } @frappe.whitelist() diff --git a/frappe/public/js/frappe/dom.js b/frappe/public/js/frappe/dom.js index 0a3890df29..b4ceac66bd 100644 --- a/frappe/public/js/frappe/dom.js +++ b/frappe/public/js/frappe/dom.js @@ -224,7 +224,7 @@ frappe.get_modal = function(title, content) { (function($) { $.fn.add_options = function(options_list) { // create options - for(var i=0; i