Browse Source

fix: ensure `Page.add_dropdown_item` returns link even if it already exists (#13420)

version-14
Sagar Vora 4 years ago
committed by GitHub
parent
commit
02765c98c9
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
  1. +5
    -3
      frappe/public/js/frappe/ui/page.js

+ 5
- 3
frappe/public/js/frappe/ui/page.js View File

@@ -409,6 +409,9 @@ frappe.ui.Page = class Page {
parent.parent().removeClass("hide");
}

let $link = this.is_in_group_button_dropdown(parent, 'li > a.grey-link', label);
if ($link) return $link;

let $li;
let $icon = ``;

@@ -440,9 +443,8 @@ frappe.ui.Page = class Page {
</li>
`);
}
var $link = $li.find("a").on("click", click);

if (this.is_in_group_button_dropdown(parent, 'li > a.grey-link', label)) return;
$link = $li.find("a").on("click", click);

if (standard) {
$li.appendTo(parent);
@@ -508,7 +510,7 @@ frappe.ui.Page = class Page {
let item = $(this).html();
return $(item).attr('data-label') === label;
});
return result.length > 0;
return result.length > 0 && result;
}

clear_btn_group(parent) {


Loading…
Cancel
Save