Ver a proveniência

Merge pull request #15791 from dj12djdjs/fix-rename-tool

fix: Specify message why document was not renamed.
version-14
mergify[bot] há 3 anos
committed by GitHub
ascendente
cometimento
05b19ccd90
Não foi encontrada uma chave conhecida para esta assinatura, na base de dados ID da chave GPG: 4AEE18F83AFDEB23
1 ficheiros alterados com 9 adições e 6 eliminações
  1. +9
    -6
      frappe/model/rename_doc.py

+ 9
- 6
frappe/model/rename_doc.py Ver ficheiro

@@ -77,13 +77,15 @@ def rename_doc(
) -> str: ) -> str:
"""Rename a doc(dt, old) to doc(dt, new) and update all linked fields of type "Link".""" """Rename a doc(dt, old) to doc(dt, new) and update all linked fields of type "Link"."""
if not frappe.db.exists(doctype, old): if not frappe.db.exists(doctype, old):
frappe.errprint(_("Failed: {0} to {1} because {0} doesn't exist.").format(old, new))
return return


if ignore_if_exists and frappe.db.exists(doctype, new): if ignore_if_exists and frappe.db.exists(doctype, new):
frappe.errprint(_("Failed: {0} to {1} because {1} already exists.").format(old, new))
return return


if old==new: if old==new:
frappe.msgprint(_('Please select a new name to rename'))
frappe.errprint(_("Ignored: {0} to {1} no changes made because old and new name are the same.").format(old, new))
return return


force = cint(force) force = cint(force)
@@ -540,15 +542,16 @@ def bulk_rename(doctype: str, rows: Optional[List[List]] = None, via_console: bo
msg = _("Successful: {0} to {1}").format(row[0], row[1]) msg = _("Successful: {0} to {1}").format(row[0], row[1])
frappe.db.commit() frappe.db.commit()
else: else:
msg = _("Ignored: {0} to {1}").format(row[0], row[1])
msg = None
except Exception as e: except Exception as e:
msg = _("** Failed: {0} to {1}: {2}").format(row[0], row[1], repr(e)) msg = _("** Failed: {0} to {1}: {2}").format(row[0], row[1], repr(e))
frappe.db.rollback() frappe.db.rollback()


if via_console:
print(msg)
else:
rename_log.append(msg)
if msg:
if via_console:
print(msg)
else:
rename_log.append(msg)


frappe.enqueue('frappe.utils.global_search.rebuild_for_doctype', doctype=doctype) frappe.enqueue('frappe.utils.global_search.rebuild_for_doctype', doctype=doctype)




Carregando…
Cancelar
Guardar