From 081c7cffe79afa34b70d037632d6f56c6d04af0a Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Mon, 17 Jul 2017 11:51:39 +0530 Subject: [PATCH] [minor] List view fixes (#3698) --- frappe/public/css/list.css | 1 + frappe/public/css/variables.css | 0 frappe/public/js/frappe/list/list_renderer.js | 14 +++++++++----- frappe/public/less/list.less | 1 + 4 files changed, 11 insertions(+), 5 deletions(-) create mode 100644 frappe/public/css/variables.css diff --git a/frappe/public/css/list.css b/frappe/public/css/list.css index a13ece1c23..bd57f1337f 100644 --- a/frappe/public/css/list.css +++ b/frappe/public/css/list.css @@ -448,6 +448,7 @@ .list-item__content--activity { justify-content: flex-end; margin-right: 5px; + min-width: 110px; } .list-item__content--activity .list-row-modified, .list-item__content--activity .avatar-small { diff --git a/frappe/public/css/variables.css b/frappe/public/css/variables.css new file mode 100644 index 0000000000..e69de29bb2 diff --git a/frappe/public/js/frappe/list/list_renderer.js b/frappe/public/js/frappe/list/list_renderer.js index 4fa52171e1..d1d07493f2 100644 --- a/frappe/public/js/frappe/list/list_renderer.js +++ b/frappe/public/js/frappe/list/list_renderer.js @@ -309,11 +309,15 @@ frappe.views.ListRenderer = Class.extend({ render_view: function (values) { var me = this; - var $list_items = $(` -
-
- `); - me.wrapper.append($list_items); + var $list_items = me.wrapper.find('.list-items'); + + if($list_items.length === 0) { + $list_items = $(` +
+
+ `); + me.wrapper.append($list_items); + } values.map(value => { const $item = $(this.get_item_html(value)); diff --git a/frappe/public/less/list.less b/frappe/public/less/list.less index 848267fb73..3b2c032236 100644 --- a/frappe/public/less/list.less +++ b/frappe/public/less/list.less @@ -550,6 +550,7 @@ &--activity { justify-content: flex-end; margin-right: 5px; + min-width: 110px; .list-row-modified, .avatar-small { margin-right: 10px;