Merge pull request #998 from anandpdoshi/anand-feb-6

Fixes for errors reported on Feb 7 2014

frappe/core/doctype/comment/comment.py

@@ -5,8 +5,8 @@ from __future__ import unicode_literals
 import frappe, json
 from frappe import _
 from frappe.website.render import clear_cache
-
 from frappe.model.document import Document
+from frappe.model.db_schema import add_column
 
 class Comment(Document):
 
@@ -20,39 +20,44 @@ class Comment(Document):
 
 	def update_comment_in_doc(self):
 		if self.comment_doctype and self.comment_docname and self.comment and self.comment_type=="Comment":
-			try:
-				_comments = self.get_comments_from_parent()
-				updated = False
-				for c in _comments:
-					if c.get("name")==self.name:
-						c["comment"] = self.comment
-						updated = True
-
-				if not updated:
-					_comments.append({
-						"comment": self.comment,
-						"by": self.comment_by or self.owner,
-						"name":self.name
-					})
-				self.update_comments_in_parent(_comments)
-			except Exception, e:
-				if e.args[0]==1054:
-					if frappe.flags.in_test:
-						return
-
-					from frappe.model.db_schema import add_column
-					add_column(self.comment_doctype, "_comments", "Text")
-					self.update_comment_in_doc()
-				elif e.args[0]==1146:
-					# no table
-					pass
-				else:
-					raise
+			_comments = self.get_comments_from_parent()
+			updated = False
+			for c in _comments:
+				if c.get("name")==self.name:
+					c["comment"] = self.comment
+					updated = True
+
+			if not updated:
+				_comments.append({
+					"comment": self.comment,
+					"by": self.comment_by or self.owner,
+					"name":self.name
+				})
+			self.update_comments_in_parent(_comments)
 
 	def get_comments_from_parent(self):
-		_comments = frappe.db.get_value(self.comment_doctype,
-			self.comment_docname, "_comments") or "[]"
-		return json.loads(_comments)
+		try:
+			_comments = frappe.db.get_value(self.comment_doctype,
+				self.comment_docname, "_comments") or "[]"
+
+			return json.loads(_comments)
+
+		except Exception, e:
+
+			if e.args[0]==1054:
+				if frappe.flags.in_test:
+					return
+
+				add_column(self.comment_doctype, "_comments", "Text")
+
+				return self.get_comments_from_parent()
+
+			elif e.args[0]==1146:
+				# no table
+				pass
+
+			else:
+				raise
 
 	def update_comments_in_parent(self, _comments):
 		# use sql, so that we do not mess with the timestamp
@@ -80,3 +85,4 @@ def on_doctype_update():
 		frappe.db.commit()
 		frappe.db.sql("""alter table `tabComment`
 			add index comment_doctype_docname_index(comment_doctype, comment_docname)""")
+

frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py

@@ -29,10 +29,10 @@ def validate(user, doctype):
 
 def get_columns_and_fields(doctype):
 	columns = ["Name:Link/{}:200".format(doctype)]
-	fields = ["name"]
+	fields = ["`name`"]
 	for df in frappe.get_meta(doctype).fields:
 		if df.in_list_view and df.fieldtype in type_map:
-			fields.append(df.fieldname)
+			fields.append("`{0}`".format(df.fieldname))
 			fieldtype = "Link/{}".format(df.options) if df.fieldtype=="Link" else df.fieldtype
 			columns.append("{label}:{fieldtype}:{width}".format(label=df.label, fieldtype=fieldtype, width=df.width or 100))
 

frappe/utils/file_manager.py

@@ -107,7 +107,7 @@ def extract_images_from_html(doc, fieldname):
 		return '<img src="{file_url}"'.format(file_url=file_url)
 
 	if content:
-		content = re.sub('<img\s*src=\s*["\'](.*?)["\']', _save_file, content)
+		content = re.sub('<img\s*src=\s*["\'](?=data:)(.*?)["\']', _save_file, content)
 		if frappe.flags.has_dataurl:
 			doc.set(fieldname, content)