From 20c9af556f6a420198fb44f02f4242f7c2b2fdce Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Sun, 19 Sep 2021 21:23:03 +0530 Subject: [PATCH 1/2] fix(Workflow Action): Pass doc to attach_print to avoid "Not Found" - Printview used to go empty for new document due to "Not Found" error in printview because that new document has not been saved in the database while processing workflow action email. --- frappe/workflow/doctype/workflow_action/workflow_action.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/workflow/doctype/workflow_action/workflow_action.py b/frappe/workflow/doctype/workflow_action/workflow_action.py index a04e9356cd..056eb0b5db 100644 --- a/frappe/workflow/doctype/workflow_action/workflow_action.py +++ b/frappe/workflow/doctype/workflow_action/workflow_action.py @@ -292,7 +292,7 @@ def get_common_email_args(doc): common_args = { 'template': 'workflow_action', 'header': 'Workflow Action', - 'attachments': [frappe.attach_print(doctype, docname , file_name=docname)], + 'attachments': [frappe.attach_print(doctype, docname, file_name=docname, doc=doc)], 'subject': subject, 'message': response } From 1553ebdc99675a99c7ffdcf02427c83cd16f31ac Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Mon, 20 Sep 2021 10:34:59 +0530 Subject: [PATCH 2/2] fix: Link workflow document --- frappe/workflow/doctype/workflow_action/workflow_action.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/workflow/doctype/workflow_action/workflow_action.py b/frappe/workflow/doctype/workflow_action/workflow_action.py index 056eb0b5db..c1ed7b8957 100644 --- a/frappe/workflow/doctype/workflow_action/workflow_action.py +++ b/frappe/workflow/doctype/workflow_action/workflow_action.py @@ -9,9 +9,10 @@ from frappe.desk.form.utils import get_pdf_link from frappe.utils.verified_command import get_signed_params, verify_request from frappe import _ from frappe.model.workflow import apply_workflow, get_workflow_name, has_approval_access, \ - get_workflow_state_field, send_email_alert, get_workflow_field_value, is_transition_condition_satisfied + get_workflow_state_field, send_email_alert, is_transition_condition_satisfied from frappe.desk.notifications import clear_doctype_notifications from frappe.utils.user import get_users_with_role +from frappe.utils.data import get_link_to_form class WorkflowAction(Document): pass @@ -287,7 +288,7 @@ def get_common_email_args(doc): response = frappe.render_template(email_template.response, vars(doc)) else: subject = _('Workflow Action') - response = _('{0}: {1}').format(doctype, docname) + response = get_link_to_form(doctype, docname, f"{doctype}: {docname}") common_args = { 'template': 'workflow_action',