Merge pull request #2984 from netchampfaris/ui-fixes

Page length always 20

frappe/desk/reportview.py

@@ -36,7 +36,8 @@ def get_form_params():
 		data["save_user_settings"] = json.loads(data["save_user_settings"])
 	else:
 		data["save_user_settings"] = True
-
+	
+	doctype = data["doctype"]
 	fields = data["fields"]
 
 	for field in fields:

frappe/public/js/frappe/list/list_renderer.js

@@ -50,7 +50,7 @@ frappe.views.ListRenderer = Class.extend({
 
 		this.order_by = this.user_settings.order_by || this.settings.order_by;
 		this.filters = this.user_settings.filters || this.settings.filters;
-		this.page_length = this.user_settings.page_length || this.settings.page_length;
+		this.page_length = this.settings.page_length;
 
 		// default filter for submittable doctype
 		if(frappe.model.is_submittable(this.doctype) && (!this.filters || !this.filters.length)) {

frappe/public/js/frappe/list/list_view.js

@@ -441,10 +441,11 @@ frappe.views.ListView = frappe.ui.BaseList.extend({
 			different = true;
 		}
 
-		if (user_settings.page_length !== args.page_length) {
-			user_settings.page_length = args.page_length || 20
-			different = true;
-		}
+		// never save page_length in user_settings
+		// if (user_settings.page_length !== args.page_length) {
+		// 	user_settings.page_length = args.page_length || 20
+		// 	different = true;
+		// }
 
 		// save fields in list settings
 		if (args.save_user_settings_fields) {