refactor: Remove unused imports & code

frappe/core/doctype/activity_log/activity_log.py

@@ -2,7 +2,6 @@
 # License: MIT. See LICENSE
 
 import frappe
-from frappe import _
 from frappe.core.utils import set_timeline_doc
 from frappe.model.document import Document
 from frappe.query_builder import DocType, Interval

frappe/core/doctype/block_module/block_module.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/communication/communication.py

@@ -20,7 +20,6 @@ from frappe.core.doctype.communication.mixins import CommunicationEmailMixin
 from frappe.core.utils import get_parent_doc
 from frappe.model.document import Document
 from frappe.utils import (
-	cstr,
 	parse_addr,
 	split_emails,
 	strip_html,

frappe/core/doctype/custom_docperm/test_custom_docperm.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Custom DocPerm')
 
 

frappe/core/doctype/custom_role/test_custom_role.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Custom Role')
 
 

frappe/core/doctype/data_import/importer.py

@@ -11,7 +11,6 @@ import frappe
 from frappe import _
 from frappe.core.doctype.version.version import get_diff
 from frappe.model import no_value_fields
-from frappe.model import table_fields as table_fieldtypes
 from frappe.utils import cint, cstr, duration_to_seconds, flt, update_progress_bar
 from frappe.utils.csvutils import get_csv_content_from_google_sheets, read_csv_content
 from frappe.utils.xlsxutils import (

frappe/core/doctype/deleted_document/test_deleted_document.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Deleted Document')
 
 

frappe/core/doctype/docperm/docperm.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/doctype/doctype.py

@@ -32,7 +32,7 @@ from frappe.model.meta import Meta
 from frappe.modules import get_doc_path, make_boilerplate
 from frappe.modules.import_file import get_file_path
 from frappe.query_builder.functions import Concat
-from frappe.utils import cint, now
+from frappe.utils import cint
 from frappe.website.utils import clear_cache
 
 

frappe/core/doctype/domain/test_domain.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 
 class TestDomain(unittest.TestCase):
 	pass

frappe/core/doctype/error_snapshot/test_error_snapshot.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Error Snapshot')
 
 

frappe/core/doctype/file/file.py

@@ -41,7 +41,6 @@ from frappe.utils.file_manager import safe_b64decode
 from frappe.utils.image import optimize_image, strip_exif_data
 
 if TYPE_CHECKING:
-	from PIL.ImageFile import ImageFile
 	from requests.models import Response
 
 

frappe/core/doctype/has_domain/has_domain.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2017, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/language/test_language.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Language')
 
 

frappe/core/doctype/module_def/test_module_def.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Module Def')
 
 

frappe/core/doctype/patch_log/patch_log.py

@@ -3,7 +3,6 @@
 
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/patch_log/test_patch_log.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Patch Log')
 
 

frappe/core/doctype/payment_gateway/payment_gateway.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/payment_gateway/test_payment_gateway.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Payment Gateway')
 
 

frappe/core/doctype/sms_parameter/sms_parameter.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/sms_settings/test_sms_settings.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 
 class TestSMSSettings(unittest.TestCase):
 	pass

frappe/core/doctype/system_settings/test_system_settings.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 
 class TestSystemSettings(unittest.TestCase):
 	pass

frappe/core/doctype/transaction_log/transaction_log.py

@@ -4,7 +4,6 @@
 import hashlib
 
 import frappe
-from frappe import _
 from frappe.model.document import Document
 from frappe.query_builder import DocType
 from frappe.utils import cint, now_datetime

frappe/core/doctype/user_email/user_email.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/doctype/user_permission/user_permission.py

@@ -8,7 +8,6 @@ from frappe import _
 from frappe.core.utils import find
 from frappe.desk.form.linked_with import get_linked_doctypes
 from frappe.model.document import Document
-from frappe.permissions import get_valid_perms, update_permission_property
 from frappe.utils import cstr
 
 

frappe/core/doctype/view_log/view_log.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2018, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/core/notifications.py

@@ -2,8 +2,6 @@
 # License: MIT. See LICENSE
 
 import frappe
-from frappe.query_builder import DocType, Interval
-from frappe.query_builder.functions import Now
 
 
 def get_notification_config():

frappe/core/page/background_jobs/background_jobs.py

@@ -1,13 +1,9 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import json
 from typing import TYPE_CHECKING, Dict, List
 
-from rq import Worker
-
 import frappe
-from frappe import _
 from frappe.utils import convert_utc_to_user_timezone
 from frappe.utils.background_jobs import get_queues, get_workers
 from frappe.utils.scheduler import is_scheduler_inactive

frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py

@@ -3,7 +3,6 @@
 
 import frappe
 import frappe.utils.user
-from frappe import _, throw
 from frappe.model import data_fieldtypes
 from frappe.permissions import check_admin_or_system_manager, rights
 

frappe/core/web_form/edit_profile/edit_profile.py

@@ -1,6 +1,3 @@
-import frappe
-
-
 def get_context(context):
 	# do your magic here
 	pass

frappe/custom/doctype/client_script/client_script.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 import frappe
-from frappe import _
 from frappe.model.document import Document
 
 

frappe/custom/doctype/client_script/test_client_script.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Client Script')
 
 

frappe/custom/doctype/customize_form_field/customize_form_field.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/custom/doctype/property_setter/test_property_setter.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Property Setter')
 
 

frappe/desk/doctype/dashboard_chart_source/dashboard_chart_source.py

@@ -5,7 +5,6 @@
 import os
 
 import frappe
-from frappe import _
 from frappe.model.document import Document
 from frappe.modules import get_module_path, scrub
 from frappe.modules.export_file import export_to_files

frappe/desk/doctype/event/event.py

@@ -18,7 +18,6 @@ from frappe.utils import (
 	cstr,
 	date_diff,
 	format_datetime,
-	get_datetime,
 	get_datetime_str,
 	getdate,
 	now_datetime,

frappe/desk/doctype/kanban_board/test_kanban_board.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Kanban Board')
 
 

frappe/desk/doctype/kanban_board_column/kanban_board_column.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/desk/doctype/list_filter/list_filter.py

@@ -2,9 +2,6 @@
 # Copyright (c) 2018, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import json
-
-import frappe
 from frappe.model.document import Document
 
 

frappe/desk/doctype/note_seen_by/note_seen_by.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/desk/doctype/notification_log/notification_log.py

@@ -7,7 +7,6 @@ from frappe import _
 from frappe.desk.doctype.notification_settings.notification_settings import (
 	is_email_notifications_enabled_for_type,
 	is_notifications_enabled,
-	set_seen_value,
 )
 from frappe.model.document import Document
 

frappe/desk/form/load.py

@@ -2,7 +2,7 @@
 # License: MIT. See LICENSE
 
 import json
-from typing import Dict, List, Union
+from typing import List, Union
 from urllib.parse import quote
 
 import frappe

frappe/desk/link_preview.py

@@ -1,5 +1,3 @@
-import json
-
 import frappe
 from frappe.model import no_value_fields, table_fields
 

frappe/desk/page/setup_wizard/install_fixtures.py

@@ -2,7 +2,6 @@
 # License: MIT. See LICENSE
 
 import frappe
-from frappe import _
 from frappe.desk.doctype.global_search_settings.global_search_settings import (
 	update_global_search_doctypes,
 )

frappe/email/doctype/email_flag_queue/email_flag_queue.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/email/doctype/email_flag_queue/test_email_flag_queue.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Email Flag Queue')
 
 

frappe/email/doctype/email_group/test_email_group.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Email Group')
 
 

frappe/email/doctype/email_group_member/test_email_group_member.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Email Group Member')
 
 

frappe/email/doctype/email_queue/test_email_queue.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Email Queue')
 
 

frappe/email/doctype/email_rule/email_rule.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2017, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/email/doctype/email_rule/test_email_rule.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 
 class TestEmailRule(unittest.TestCase):
 	pass

frappe/email/doctype/email_unsubscribe/test_email_unsubscribe.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Email Unsubscribe')
 
 

frappe/email/doctype/newsletter/test_newsletter.py

@@ -7,7 +7,6 @@ from typing import Union
 from unittest.mock import MagicMock, PropertyMock, patch
 
 import frappe
-from frappe.desk.form.load import run_onload
 from frappe.email.doctype.newsletter.exceptions import (
 	NewsletterAlreadySentError,
 	NoRecipientFoundError,

frappe/email/doctype/newsletter_email_group/newsletter_email_group.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2015, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/email/doctype/notification_recipient/notification_recipient.py

@@ -2,7 +2,6 @@
 # Copyright (c) 2018, Frappe Technologies and contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/email/doctype/unhandled_email/test_unhandled_email.py

@@ -3,8 +3,6 @@
 # License: MIT. See LICENSE
 import unittest
 
-import frappe
-
 # test_records = frappe.get_test_records('Unhandled Emails')
 
 

frappe/email/smtp.py

@@ -1,15 +1,13 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import email.utils
 import smtplib
-import sys
 
 import _socket
 
 import frappe
 from frappe import _
-from frappe.utils import cint, cstr, parse_addr
+from frappe.utils import cint, cstr
 
 CONNECTION_FAILED = _("Could not connect to outgoing email server")
 AUTH_ERROR_TITLE = _("Invalid Credentials")

frappe/geo/doctype/country/country.py

@@ -1,7 +1,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import frappe
 from frappe.model.document import Document
 
 

frappe/geo/doctype/currency/currency.py

@@ -2,7 +2,6 @@
 # License: MIT. See LICENSE
 
 import frappe
-from frappe import _, throw
 from frappe.model.document import Document
 
 

frappe/tests/test_commands.py

@@ -7,7 +7,6 @@ import importlib
 import json
 import os
 import shlex
-import shutil
 import subprocess
 import unittest
 from contextlib import contextmanager

frappe/tests/test_scheduler.py

@@ -1,12 +1,10 @@
 import time
 from unittest import TestCase
 
-from dateutil.relativedelta import relativedelta
-
 import frappe
 from frappe.core.doctype.scheduled_job_type.scheduled_job_type import sync_jobs
 from frappe.utils import add_days, get_datetime
-from frappe.utils.background_jobs import enqueue, get_jobs
+from frappe.utils.background_jobs import enqueue
 from frappe.utils.doctor import purge_pending_jobs
 from frappe.utils.scheduler import enqueue_events, is_dormant, schedule_jobs_based_on_activity
 

frappe/utils/dashboard.py

@@ -7,7 +7,7 @@ from os.path import join
 import frappe
 from frappe import _
 from frappe.modules.import_file import import_file_by_path
-from frappe.utils import add_to_date, cint, get_link_to_form
+from frappe.utils import cint, get_link_to_form
 
 
 def cache_source(function):

frappe/utils/doctor.py

@@ -20,8 +20,8 @@ def purge_pending_jobs(event=None, site=None, queue=None):
 	mintues and would any leave daily, hourly and weekly tasks
 	"""
 	purged_task_count = 0
-	for queue in get_queue_list(queue):
-		q = get_queue(queue)
+	for _queue in get_queue_list(queue):
+		q = get_queue(_queue)
 		for job in q.jobs:
 			if site and event:
 				if job.kwargs["site"] == site and job.kwargs["event"] == event:

frappe/utils/file_manager.py

@@ -7,23 +7,13 @@ import io
 import json
 import mimetypes
 import os
-import re
 from copy import copy
 from urllib.parse import unquote
 
 import frappe
 from frappe import _, conf
 from frappe.query_builder.utils import DocType
-from frappe.utils import (
-	call_hook_method,
-	cint,
-	cstr,
-	encode,
-	get_files_path,
-	get_hook_method,
-	random_string,
-)
-from frappe.utils.image import optimize_image
+from frappe.utils import call_hook_method, cint, cstr, encode, get_files_path, get_hook_method
 
 
 class MaxFileSizeReachedError(frappe.ValidationError):

frappe/utils/identicon.py

@@ -100,8 +100,6 @@ class Identicon(object):
 		if format.upper() not in Image.SAVE:
 			Image.init()
 		save_handler = Image.SAVE[format.upper()]
-		try:
-			save_handler(self.image, fp, "")
-		finally:
-			fp.seek(0)
-			return "data:image/png;base64,{0}".format(base64.b64encode(fp.read()))
+		save_handler(self.image, fp, "")
+		fp.seek(0)
+		return "data:image/png;base64,{0}".format(base64.b64encode(fp.read()))

frappe/utils/nestedset.py

@@ -15,7 +15,7 @@ from typing import Iterator
 import frappe
 from frappe import _
 from frappe.model.document import Document
-from frappe.query_builder import DocType, Order
+from frappe.query_builder import Order
 from frappe.query_builder.functions import Coalesce, Max
 from frappe.query_builder.utils import DocType
 

frappe/utils/print_format.py

@@ -5,7 +5,7 @@ from PyPDF2 import PdfFileWriter
 import frappe
 from frappe import _
 from frappe.core.doctype.access_log.access_log import make_access_log
-from frappe.utils.pdf import cleanup, get_pdf
+from frappe.utils.pdf import get_pdf
 
 no_cache = 1
 

frappe/workflow/doctype/workflow_action/workflow_action.py

@@ -197,7 +197,7 @@ def update_completed_workflow_actions(doc, user=None, workflow=None, workflow_st
 	if not allowed_roles:
 		return
 	if workflow_action := get_workflow_action_by_role(doc, allowed_roles):
-		update_completed_workflow_actions_using_role(doc, user, allowed_roles, workflow_action)
+		update_completed_workflow_actions_using_role(user, workflow_action)
 	else:
 		# backwards compatibility
 		# for workflow actions saved using user
@@ -238,9 +238,7 @@ def get_workflow_action_by_role(doc, allowed_roles):
 	).run(as_dict=True)
 
 
-def update_completed_workflow_actions_using_role(
-	doc, user=None, allowed_roles=set(), workflow_action=None
-):
+def update_completed_workflow_actions_using_role(user=None, workflow_action=None):
 	user = user if user else frappe.session.user
 	WorkflowAction = DocType("Workflow Action")
 

frappe/www/login.py

@@ -1,8 +1,6 @@
 # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
 # License: MIT. See LICENSE
 
-import json
-
 import frappe
 import frappe.utils
 from frappe import _
@@ -11,9 +9,13 @@ from frappe.integrations.doctype.ldap_settings.ldap_settings import LDAPSettings
 from frappe.integrations.oauth2_logins import decoder_compat
 from frappe.utils.html_utils import get_icon_html
 from frappe.utils.jinja import guess_is_path
-from frappe.utils.oauth import get_oauth2_authorize_url, get_oauth_keys
-from frappe.utils.oauth import login_oauth_user as _login_oauth_user
-from frappe.utils.oauth import login_via_oauth2, login_via_oauth2_id_token, redirect_post_login
+from frappe.utils.oauth import (
+	get_oauth2_authorize_url,
+	get_oauth_keys,
+	login_via_oauth2,
+	login_via_oauth2_id_token,
+	redirect_post_login,
+)
 from frappe.utils.password import get_decrypted_password
 from frappe.website.utils import get_home_page