From 2ac1c45c664af135bdaefc934ea258a01d76661f Mon Sep 17 00:00:00 2001
From: Gavin D'souza <gavin18d@gmail.com>
Date: Wed, 14 Jul 2021 20:12:10 +0530
Subject: [PATCH] refactor: Maintain common list for Frappe Coverage settings

* Maintain common settings for coverage settings of parallel and base test suites
* Expand FRAPPE_EXCLUSIONS list based on coveralls.io report
---
 frappe/commands/utils.py       | 24 ++++-------------------
 frappe/coverage.py             | 35 ++++++++++++++++++++++++++++++++++
 frappe/parallel_test_runner.py | 25 ++++--------------------
 3 files changed, 43 insertions(+), 41 deletions(-)
 create mode 100644 frappe/coverage.py

diff --git a/frappe/commands/utils.py b/frappe/commands/utils.py
index 212642e01b..874ec90d47 100644
--- a/frappe/commands/utils.py
+++ b/frappe/commands/utils.py
@@ -551,32 +551,16 @@ def run_tests(context, app=None, module=None, doctype=None, test=(), profile=Fal
 
 	if coverage:
 		from coverage import Coverage
+		from frappe.coverage import STANDARD_INCLUSIONS, STANDARD_EXCLUSIONS, FRAPPE_EXCLUSIONS
 
 		# Generate coverage report only for app that is being tested
 		source_path = os.path.join(get_bench_path(), 'apps', app or 'frappe')
-		incl = [
-			'*.py',
-		]
-		omit = [
-			'*.js',
-			'*.xml',
-			'*.pyc',
-			'*.css',
-			'*.less',
-			'*.scss',
-			'*.vue',
-			'*.html',
-			'*/test_*',
-			'*/node_modules/*',
-			'*/doctype/*/*_dashboard.py',
-			'*/patches/*',
-		]
+		omit = STANDARD_EXCLUSIONS[:]
 
 		if not app or app == 'frappe':
-			omit.append('*/tests/*')
-			omit.append('*/commands/*')
+			omit.extend(FRAPPE_EXCLUSIONS)
 
-		cov = Coverage(source=[source_path], omit=omit, include=incl)
+		cov = Coverage(source=[source_path], omit=omit, include=STANDARD_INCLUSIONS)
 		cov.start()
 
 	ret = frappe.test_runner.main(app, module, doctype, context.verbose, tests=tests,
diff --git a/frappe/coverage.py b/frappe/coverage.py
new file mode 100644
index 0000000000..a59c24a714
--- /dev/null
+++ b/frappe/coverage.py
@@ -0,0 +1,35 @@
+# Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and Contributors
+# MIT License. See LICENSE
+"""
+	frappe.coverage
+	~~~~~~~~~~~~~~~~
+
+	Coverage settings for frappe
+"""
+
+STANDARD_INCLUSIONS = ["*.py"]
+
+STANDARD_EXCLUSIONS = [
+	'*.js',
+	'*.xml',
+	'*.pyc',
+	'*.css',
+	'*.less',
+	'*.scss',
+	'*.vue',
+	'*.html',
+	'*/test_*',
+	'*/node_modules/*',
+	'*/doctype/*/*_dashboard.py',
+	'*/patches/*',
+]
+
+FRAPPE_EXCLUSIONS = [
+	"*/tests/*",
+	"*/commands/*",
+	"*/frappe/change_log/*",
+	"*/frappe/exceptions*",
+	"*frappe/setup.py",
+	"*/doctype/*/*_dashboard.py",
+	"*/patches/*",
+]
diff --git a/frappe/parallel_test_runner.py b/frappe/parallel_test_runner.py
index 2f83b88572..6265498c96 100644
--- a/frappe/parallel_test_runner.py
+++ b/frappe/parallel_test_runner.py
@@ -111,33 +111,16 @@ class ParallelTestRunner():
 		if self.with_coverage:
 			from coverage import Coverage
 			from frappe.utils import get_bench_path
+			from frappe.coverage import STANDARD_INCLUSIONS, STANDARD_EXCLUSIONS, FRAPPE_EXCLUSIONS
 
 			# Generate coverage report only for app that is being tested
 			source_path = os.path.join(get_bench_path(), 'apps', self.app)
-			incl = [
-				'*.py',
-			]
-			omit = [
-				'*.js',
-				'*.xml',
-				'*.pyc',
-				'*.css',
-				'*.less',
-				'*.scss',
-				'*.vue',
-				'*.pyc',
-				'*.html',
-				'*/test_*',
-				'*/node_modules/*',
-				'*/doctype/*/*_dashboard.py',
-				'*/patches/*',
-			]
+			omit = STANDARD_EXCLUSIONS[:]
 
 			if self.app == 'frappe':
-				omit.append('*/tests/*')
-				omit.append('*/commands/*')
+				omit.extend(FRAPPE_EXCLUSIONS)
 
-			self.coverage = Coverage(source=[source_path], omit=omit, include=incl)
+			self.coverage = Coverage(source=[source_path], omit=omit, include=STANDARD_INCLUSIONS)
 			self.coverage.start()
 
 	def save_coverage(self):