chore: Deprecate backup script + minor refactors

frappe/database/mariadb/database.py

@@ -123,7 +123,7 @@ class MariaDBConnectionUtil:
 				"cert": frappe.conf.db_ssl_cert,
 				"key": frappe.conf.db_ssl_key,
 			}
-			conn_settings.update(ssl_params)
+			conn_settings |= ssl_params
 		return conn_settings
 
 

frappe/tests/test_db.py

@@ -135,7 +135,7 @@ class TestDB(unittest.TestCase):
 		test_inputs = [
 			{"fieldtype": fieldtype, "value": value} for fieldtype, value in values_dict.items()
 		]
-		for fieldtype in values_dict.keys():
+		for fieldtype in values_dict:
 			create_custom_field(
 				"Print Settings",
 				{

frappe/tests/test_fmt_datetime.py

@@ -125,5 +125,5 @@ class TestFmtDatetime(unittest.TestCase):
 			for time_fmt, valid_time in test_time_formats.items():
 				frappe.db.set_default("time_format", time_fmt)
 				frappe.local.user_time_format = None
-				valid_fmt = valid_date + " " + valid_time
+				valid_fmt = f"{valid_date} {valid_time}"
 				self.assertEqual(format_datetime(test_datetime), valid_fmt)

frappe/utils/backups.py

@@ -697,6 +697,14 @@ def backup(
 if __name__ == "__main__":
 	import sys
 
+	from frappe.utils.commands import warn
+
+	warn(
+		"Calling the backup script directly is deprecated. "
+		"Use the backup command instead. This script will be removed in Frappe v15.",
+		category=DeprecationWarning,
+	)
+
 	cmd = sys.argv[1]
 
 	db_type = "mariadb"