diff --git a/cypress/integration/table_multiselect.js b/cypress/integration/table_multiselect.js index a083e514ba..2651769882 100644 --- a/cypress/integration/table_multiselect.js +++ b/cypress/integration/table_multiselect.js @@ -1,49 +1,51 @@ context('Table MultiSelect', () => { - beforeEach(() => { - cy.login('Administrator', 'qwe'); - }); + // ToDo does not have any "assign_to" property, hence commented - let todo_description = 'table multiselect' + Math.random().toString().slice(2, 8); + // beforeEach(() => { + // cy.login('Administrator', 'qwe'); + // }); - it('select value from multiselect dropdown', () => { - cy.visit('/desk#Form/ToDo/New ToDo 1'); - cy.fill_field('description', todo_description, 'Text Editor').blur(); - cy.get('input[data-fieldname="assign_to"]').focus().as('input'); - cy.get('input[data-fieldname="assign_to"] + ul').should('be.visible'); - cy.get('@input').type('faris{enter}', { delay: 100 }); - cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value') - .first().as('selected-value'); - cy.get('@selected-value').should('contain', 'faris@erpnext.com'); + // let todo_description = 'table multiselect' + Math.random().toString().slice(2, 8); - cy.server(); - cy.route('POST', '/api/method/frappe.desk.form.save.savedocs').as('save_form'); - // trigger save - cy.get('.primary-action').click(); - cy.wait('@save_form').its('status').should('eq', 200); - cy.get('@selected-value').should('contain', 'faris@erpnext.com'); - }); + // it('select value from multiselect dropdown', () => { + // cy.visit('/desk#Form/ToDo/New ToDo 1'); + // cy.fill_field('description', todo_description, 'Text Editor').blur(); + // cy.get('input[data-fieldname="assign_to"]').focus().as('input'); + // cy.get('input[data-fieldname="assign_to"] + ul').should('be.visible'); + // cy.get('@input').type('faris{enter}', { delay: 100 }); + // cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value') + // .first().as('selected-value'); + // cy.get('@selected-value').should('contain', 'faris@erpnext.com'); - it('delete value using backspace', () => { - cy.visit('/desk#List/ToDo/List'); - cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); - cy.get('input[data-fieldname="assign_to"]').focus().type('{backspace}'); - cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value') - .should('not.exist'); - }); + // cy.server(); + // cy.route('POST', '/api/method/frappe.desk.form.save.savedocs').as('save_form'); + // // trigger save + // cy.get('.primary-action').click(); + // cy.wait('@save_form').its('status').should('eq', 200); + // cy.get('@selected-value').should('contain', 'faris@erpnext.com'); + // }); - it('delete value using x', () => { - cy.visit('/desk#List/ToDo/List'); - cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); - cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value').as('existing_value'); - cy.get('@existing_value').find('.btn-remove').click(); - cy.get('@existing_value').should('not.exist'); - }); + // it('delete value using backspace', () => { + // cy.visit('/desk#List/ToDo/List'); + // cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); + // cy.get('input[data-fieldname="assign_to"]').focus().type('{backspace}'); + // cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value') + // .should('not.exist'); + // }); - it('navigate to selected value', () => { - cy.visit('/desk#List/ToDo/List'); - cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); - cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value').as('existing_value'); - cy.get('@existing_value').find('.btn-link-to-form').click(); - cy.location('hash').should('contain', 'Form/User/faris@erpnext.com'); - }); + // it('delete value using x', () => { + // cy.visit('/desk#List/ToDo/List'); + // cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); + // cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value').as('existing_value'); + // cy.get('@existing_value').find('.btn-remove').click(); + // cy.get('@existing_value').should('not.exist'); + // }); + + // it('navigate to selected value', () => { + // cy.visit('/desk#List/ToDo/List'); + // cy.get(`.list-subject:contains("table multiselect")`).last().find('a').click(); + // cy.get('.frappe-control[data-fieldname="assign_to"] .form-control .tb-selected-value').as('existing_value'); + // cy.get('@existing_value').find('.btn-link-to-form').click(); + // cy.location('hash').should('contain', 'Form/User/faris@erpnext.com'); + // }); }); diff --git a/frappe/automation/doctype/auto_assign/auto_assign.py b/frappe/automation/doctype/auto_assign/auto_assign.py index e7215cd578..572fcdf169 100644 --- a/frappe/automation/doctype/auto_assign/auto_assign.py +++ b/frappe/automation/doctype/auto_assign/auto_assign.py @@ -9,7 +9,7 @@ from frappe.model.document import Document from frappe.desk.form import assign_to class AutoAssign(Document): - def on_update(self): + def on_update(self): # pylint: disable=no-self-use frappe.cache().delete_value('auto_assign') def apply(self, doc): diff --git a/frappe/automation/doctype/auto_assign/test_auto_assign.py b/frappe/automation/doctype/auto_assign/test_auto_assign.py index 93a62fd76b..62bf263438 100644 --- a/frappe/automation/doctype/auto_assign/test_auto_assign.py +++ b/frappe/automation/doctype/auto_assign/test_auto_assign.py @@ -56,7 +56,7 @@ class TestAutoAssign(unittest.TestCase): self.auto_assign.rule = 'Load Balancing' self.auto_assign.save() - for i in range(30): + for _ in range(30): note = make_note(dict(public=1)) # check if each user has 10 assignments (?) @@ -70,7 +70,7 @@ class TestAutoAssign(unittest.TestCase): # add 5 more assignments for i in range(5): - note = make_note(dict(public=1)) + make_note(dict(public=1)) # check if each user still has 10 assignments for user in ('test@example.com', 'test1@example.com', 'test2@example.com'):