Merge pull request #1227 from nabinhait/unique_constraint

[fix] Unique constraint check in db_insert and bypassed for blank values (not null)

frappe/exceptions.py

@@ -53,3 +53,4 @@ class EmptyTableError(ValidationError): pass
 class LinkExistsError(ValidationError): pass
 class InvalidEmailAddressError(ValidationError): pass
 class TemplateNotFoundError(ValidationError): pass
+class UniqueValidationError(ValidationError): pass

frappe/model/base_document.py

@@ -184,10 +184,9 @@ class BaseDocument(object):
 
 				elif df.fieldtype in ("Datetime", "Date") and d[fieldname]=="":
 					d[fieldname] = None
-
-			if d[fieldname]=="":
-				df = self.meta.get_field(fieldname)
-				if df and df.fieldtype in ("Datetime", "Date"):
+					
+				elif df.get("unique") and cstr(d[fieldname]).strip()=="":
+					# unique empty field should be set to None
 					d[fieldname] = None
 
 		return d
@@ -264,15 +263,23 @@ class BaseDocument(object):
 					values = ", ".join(["%s"] * len(columns))
 				), d.values())
 		except Exception, e:
-			if e.args[0]==1062 and "PRIMARY" in cstr(e.args[1]):
-				if self.meta.autoname=="hash":
-					# hash collision? try again
-					self.name = None
-					self.db_insert()
-					return
-				type, value, traceback = sys.exc_info()
-				frappe.msgprint(_("Duplicate name {0} {1}").format(self.doctype, self.name))
-				raise frappe.DuplicateEntryError, (self.doctype, self.name, e), traceback
+			if e.args[0]==1062:
+				if "PRIMARY" in cstr(e.args[1]):
+					if self.meta.autoname=="hash":
+						# hash collision? try again
+						self.name = None
+						self.db_insert()
+						return
+						
+					type, value, traceback = sys.exc_info()
+					frappe.msgprint(_("Duplicate name {0} {1}").format(self.doctype, self.name))
+					raise frappe.DuplicateEntryError, (self.doctype, self.name, e), traceback
+				
+				elif "Duplicate" in cstr(e.args[1]):
+					# unique constraint
+					self.show_unique_validation_message(e)
+				else:
+					raise
 			else:
 				raise
 
@@ -292,13 +299,17 @@ class BaseDocument(object):
 					values = ", ".join(["`"+c+"`=%s" for c in columns])
 				), d.values() + [d.get("name")])
 		except Exception, e:
-			if e.args[0]==1062:
-				type, value, traceback = sys.exc_info()
-				fieldname = str(e).split("'")[-2]
-				frappe.msgprint(_("{0} must be unique".format(self.meta.get_label(fieldname))))
-				raise frappe.ValidationError, (self.doctype, self.name, e), traceback
+			if e.args[0]==1062 and "Duplicate" in cstr(e.args[1]):
+				self.show_unique_validation_message(e)
 			else:
 				raise
+				
+	def show_unique_validation_message(self, e):
+		type, value, traceback = sys.exc_info()
+		fieldname = str(e).split("'")[-2]
+		label = fieldname if fieldname.startswith("unique_") else self.meta.get_label(fieldname)
+		frappe.msgprint(_("{0} must be unique".format(label)))
+		raise frappe.UniqueValidationError, (self.doctype, self.name, e), traceback
 
 	def db_set(self, fieldname, value, update_modified=True):
 		self.set(fieldname, value)