From 337bdc976c2a2c60c50b0924c0d9fad0d8935c6a Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Tue, 30 Mar 2021 18:35:44 +0530 Subject: [PATCH] fix(reportview): test --- frappe/desk/reportview.py | 9 +++++---- frappe/tests/test_db_query.py | 3 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/frappe/desk/reportview.py b/frappe/desk/reportview.py index e9914ef4cf..2d6c18440a 100644 --- a/frappe/desk/reportview.py +++ b/frappe/desk/reportview.py @@ -59,9 +59,7 @@ def validate_args(data): return data def validate_fields(data): - if update_wildcard_field_param(data): - # no need to validate wildcard fields - return + wildcard = update_wildcard_field_param(data) for field in data.fields or []: fieldname = extract_fieldname(field) @@ -71,7 +69,10 @@ def validate_fields(data): meta, df = get_meta_and_docfield(fieldname, data) if not df: - raise_invalid_field(fieldname) + if wildcard: + continue + else: + raise_invalid_field(fieldname) # remove the field from the query if the report hide flag is set and current view is Report if df.report_hide and data.view == 'Report': diff --git a/frappe/tests/test_db_query.py b/frappe/tests/test_db_query.py index 836bb4bbf5..085c257550 100644 --- a/frappe/tests/test_db_query.py +++ b/frappe/tests/test_db_query.py @@ -17,6 +17,9 @@ from frappe.utils.testutils import add_custom_field, clear_custom_fields test_dependencies = ['User', 'Blog Post', 'Blog Category', 'Blogger'] class TestReportview(unittest.TestCase): + def setUp(self): + frappe.set_user("Administrator") + def test_basic(self): self.assertTrue({"name":"DocType"} in DatabaseQuery("DocType").execute(limit_page_length=None))