From 3ed3b7badc13a26bf5a350432416e4f9e4efacbf Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Wed, 29 Nov 2017 16:34:28 +0530 Subject: [PATCH] [fix] tag error for hidden forms --- frappe/public/js/frappe/ui/tags.js | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/frappe/public/js/frappe/ui/tags.js b/frappe/public/js/frappe/ui/tags.js index 4fef3135cf..f99da28ff7 100644 --- a/frappe/public/js/frappe/ui/tags.js +++ b/frappe/public/js/frappe/ui/tags.js @@ -12,8 +12,24 @@ frappe.ui.TagEditor = Class.extend({ - docname */ $.extend(this, opts); + + this.setup_taggle(); + + if (!this.user_tags) { + this.user_tags = ""; + } + this.initialized = true; + this.refresh(this.user_tags); + }, + setup_taggle: function() { var me = this; - this.wrapper = $('
').appendTo(this.parent) + + // hidden form, does not have parent + if (!this.parent) { + return; + } + + this.wrapper = $('
').appendTo(this.parent); if(!this.wrapper.length) return; var id = frappe.dom.set_unique_id(this.wrapper); this.taggle = new Taggle(id, { @@ -48,12 +64,8 @@ frappe.ui.TagEditor = Class.extend({ } } }); - if (!this.user_tags) { - this.user_tags = ""; - } - this.initialized = true; - this.refresh(this.user_tags); this.setup_awesomplete(); + this.setup_complete = true; }, setup_awesomplete: function() { var me = this; @@ -100,8 +112,7 @@ frappe.ui.TagEditor = Class.extend({ }, refresh: function(user_tags) { var me = this; - if(!me.initialized || me.refreshing) - return; + if (!this.initialized || !this.setup_complete || this.refreshing) return; me.refreshing = true; try {