From d630b340f0224abab33acaef10967a5d91295bb0 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Thu, 16 Jul 2015 18:01:00 +0530 Subject: [PATCH] [fix] autocomplete: do not select on hover --- frappe/public/js/frappe/form/control.js | 1 + frappe/public/js/frappe/ui/filters/filters.js | 3 +-- frappe/public/js/frappe/views/communication.js | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/form/control.js b/frappe/public/js/frappe/form/control.js index ea3a14cbe6..4b2e5cf7b7 100644 --- a/frappe/public/js/frappe/form/control.js +++ b/frappe/public/js/frappe/form/control.js @@ -1091,6 +1091,7 @@ frappe.ui.form.ControlLink = frappe.ui.form.ControlData.extend({ me.autocomplete_open = false; }, focus: function( event, ui ) { + event.preventDefault(); if(ui.item.action) { return false; } diff --git a/frappe/public/js/frappe/ui/filters/filters.js b/frappe/public/js/frappe/ui/filters/filters.js index c414140a7f..31f49c1032 100644 --- a/frappe/public/js/frappe/ui/filters/filters.js +++ b/frappe/public/js/frappe/ui/filters/filters.js @@ -402,8 +402,7 @@ frappe.ui.FieldSelect = Class.extend({ minLength: 0, autoFocus: true, focus: function(event, ui) { - ui.item && me.$select.val(ui.item.label); - return false; + event.preventDefault(); }, select: function(event, ui) { me.selected_doctype = ui.item.doctype; diff --git a/frappe/public/js/frappe/views/communication.js b/frappe/public/js/frappe/views/communication.js index 4f979470af..70227ff056 100644 --- a/frappe/public/js/frappe/views/communication.js +++ b/frappe/public/js/frappe/views/communication.js @@ -426,8 +426,7 @@ frappe.views.CommunicationComposer = Class.extend({ }, appendTo: this.dialog.$wrapper, focus: function() { - // prevent value inserted on focus - return false; + event.preventDefault(); }, select: function( event, ui ) { var terms = split( this.value ); @@ -443,4 +442,3 @@ frappe.views.CommunicationComposer = Class.extend({ }); } }); -