From 40df626b00874079942090de9c1b47b44e69a089 Mon Sep 17 00:00:00 2001 From: mbauskar Date: Thu, 14 Sep 2017 11:44:17 +0530 Subject: [PATCH] [minor] can not find users in user mentioned if username is not defined for any user --- frappe/public/js/frappe/form/footer/timeline.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/footer/timeline.js b/frappe/public/js/frappe/form/footer/timeline.js index facf4d6298..03d68a8221 100644 --- a/frappe/public/js/frappe/form/footer/timeline.js +++ b/frappe/public/js/frappe/form/footer/timeline.js @@ -657,7 +657,7 @@ frappe.ui.form.Timeline = Class.extend({ var valid_users = Object.keys(frappe.boot.user_info) .filter(user => !["Administrator", "Guest"].includes(user)); - return valid_users.map(user => frappe.boot.user_info[user].username); + return valid_users.map(user => frappe.boot.user_info[user].username || frappe.boot.user_info[user].name); }, setup_comment_like: function() {