diff --git a/frappe/__init__.py b/frappe/__init__.py index 869dfc9b2c..cb012350f3 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -982,7 +982,7 @@ def respond_as_web_page(title, html, success=None, http_status_code=None, contex local.message = html local.message_success = success local.response['type'] = 'page' - local.response['page_name'] = 'message' + local.response['route'] = 'message' if http_status_code: local.response['http_status_code'] = http_status_code diff --git a/frappe/commands/docs.py b/frappe/commands/docs.py index 16242f6c1d..4f52eac73d 100644 --- a/frappe/commands/docs.py +++ b/frappe/commands/docs.py @@ -4,55 +4,6 @@ import os import frappe from frappe.commands import pass_context -@click.command('make-docs') -@pass_context -@click.argument('app') -@click.argument('docs_version') -def make_docs(context, app, docs_version): - "Setup docs in target folder of target app" - from frappe.utils.setup_docs import setup_docs - for site in context.sites: - try: - frappe.init(site=site) - frappe.connect() - make = setup_docs(app) - make.build(docs_version) - finally: - frappe.destroy() - -@click.command('sync-docs') -@pass_context -@click.argument('app') -def sync_docs(context, app): - "Sync docs from /docs folder into the database (Web Page)" - from frappe.utils.setup_docs import setup_docs - for site in context.sites: - try: - frappe.init(site=site) - frappe.connect() - make = setup_docs(app) - make.sync_docs() - finally: - frappe.destroy() - - -@click.command('write-docs') -@pass_context -@click.argument('app') -@click.argument('target') -@click.option('--local', default=False, is_flag=True, help='Run app locally') -def write_docs(context, app, target, local=False): - "Setup docs in target folder of target app" - from frappe.utils.setup_docs import setup_docs - for site in context.sites: - try: - frappe.init(site=site) - frappe.connect() - make = setup_docs(app) - make.make_docs(target, local) - finally: - frappe.destroy() - @click.command('build-docs') @pass_context @click.argument('app') @@ -93,7 +44,6 @@ def _build_docs_once(site, app, docs_version, target, local, only_content_update if not only_content_updated: make.build(docs_version) - make.sync_docs() make.make_docs(target, local) @@ -101,8 +51,5 @@ def _build_docs_once(site, app, docs_version, target, local, only_content_update frappe.destroy() commands = [ - build_docs, - make_docs, - sync_docs, - write_docs, + build_docs ] diff --git a/frappe/core/doctype/communication/comment.py b/frappe/core/doctype/communication/comment.py index 5ac6d3053d..d78ca3b612 100644 --- a/frappe/core/doctype/communication/comment.py +++ b/frappe/core/doctype/communication/comment.py @@ -148,8 +148,8 @@ def update_comments_in_parent(reference_doctype, reference_name, _comments): else: if not frappe.flags.in_patch: reference_doc = frappe.get_doc(reference_doctype, reference_name) - if getattr(reference_doc, "get_route", None): - clear_cache(reference_doc.get_route()) + if getattr(reference_doc, "route", None): + clear_cache(reference_doc.route) def add_info_comment(**kwargs): kwargs.update({ diff --git a/frappe/desk/doctype/event/event.py b/frappe/desk/doctype/event/event.py index b425715a9e..f3a752e43e 100644 --- a/frappe/desk/doctype/event/event.py +++ b/frappe/desk/doctype/event/event.py @@ -11,10 +11,6 @@ from frappe.utils.user import get_enabled_system_users weekdays = ["monday", "tuesday", "wednesday", "thursday", "friday", "saturday", "sunday"] class Event(Document): - def get_route(self): - """for test-case""" - return "/Event/" + self.name - def validate(self): if self.starts_on and self.ends_on and self.starts_on > self.ends_on: frappe.msgprint(frappe._("Event end must be after start"), raise_exception=True) diff --git a/frappe/integrations/doctype/dropbox_backup/dropbox_backup.py b/frappe/integrations/doctype/dropbox_backup/dropbox_backup.py index 50dc9da115..c9f7dd1539 100644 --- a/frappe/integrations/doctype/dropbox_backup/dropbox_backup.py +++ b/frappe/integrations/doctype/dropbox_backup/dropbox_backup.py @@ -127,7 +127,7 @@ def dropbox_callback(oauth_token=None, not_approved=False): frappe.db.commit() frappe.response['type'] = 'page' - frappe.response['page_name'] = 'message.html' + frappe.response['route'] = 'message.html' def backup_to_dropbox(): if not frappe.db: diff --git a/frappe/patches.txt b/frappe/patches.txt index 36e26d03b7..b331e4f7dd 100644 --- a/frappe/patches.txt +++ b/frappe/patches.txt @@ -131,3 +131,4 @@ frappe.patches.v7_0.update_send_after_in_bulk_email frappe.patches.v7_0.setup_list_settings execute:frappe.db.sql('''delete from `tabSingles` where doctype="Email Settings"''') # 2016-06-13 execute:frappe.db.sql("delete from `tabWeb Page` where ifnull(template_path, '')!=''") +frappe.patches.v7_0.re_route diff --git a/frappe/patches/v7_0/re_route.py b/frappe/patches/v7_0/re_route.py new file mode 100644 index 0000000000..f340328de7 --- /dev/null +++ b/frappe/patches/v7_0/re_route.py @@ -0,0 +1,13 @@ +import frappe + +def execute(): + update_routes(['Blog Post', 'Blog Category', 'Web Page']) + +def update_routes(doctypes): + """Patch old routing system""" + for d in doctypes: + try: + frappe.db.sql("""update `tab{0}` set route = concat(ifnull(parent_website_route, ""), + if(ifnull(parent_website_route, "")="", "", "/"), page_name)""".format(d)) + except Exception, e: + if e.args[0]!=1054: raise e diff --git a/frappe/templates/generators/blog_post.html b/frappe/templates/generators/blog_post.html index 9637eabf66..b2c8079141 100644 --- a/frappe/templates/generators/blog_post.html +++ b/frappe/templates/generators/blog_post.html @@ -11,7 +11,7 @@
By {{ blogger_info and blogger_info.full_name or full_name }} {{ frappe.format_date(published_on) }} - {{ blog_category }} + {{ blog_category }} {{ comment_text }}
diff --git a/frappe/templates/generators/web_form.html b/frappe/templates/generators/web_form.html index c8816801b3..7472ca1c32 100644 --- a/frappe/templates/generators/web_form.html +++ b/frappe/templates/generators/web_form.html @@ -147,7 +147,7 @@{{ post.intro }}
- By {{ post.full_name }} - {{ frappe.format_date(post.published_on) }} + By {{ post.full_name }} + {{ frappe.format_date(post.published_on) }} - {{ post.blog_category }} + {{ post.blog_category }} {{ post.comment_text }}