From 3d77f544fdaccac472c5ea72a9c603554aacc469 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Tue, 11 Jan 2022 10:09:14 +0530
Subject: [PATCH] fix(datetime): Fix side-effect due to `__run_link_triggers`

- `__run_link_triggers` should only affect link fields
- Removed usage of `__run_link_triggers` from base control and introduce `force_set_value` for more explicit action.
---
 .../public/js/frappe/form/controls/base_control.js | 14 +++++++-------
 frappe/public/js/frappe/form/form.js               |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/frappe/public/js/frappe/form/controls/base_control.js b/frappe/public/js/frappe/form/controls/base_control.js
index 7af0705e78..ce871c50cb 100644
--- a/frappe/public/js/frappe/form/controls/base_control.js
+++ b/frappe/public/js/frappe/form/controls/base_control.js
@@ -148,8 +148,9 @@ frappe.ui.form.Control = class BaseControl {
 			return this.doc[this.df.fieldname];
 		}
 	}
-	set_value(value) {
-		return this.validate_and_set_in_model(value);
+
+	set_value(value, force_set_value=false) {
+		return this.validate_and_set_in_model(value, null, force_set_value);
 	}
 	parse_validate_and_set_in_model(value, e) {
 		if(this.parse) {
@@ -157,12 +158,11 @@ frappe.ui.form.Control = class BaseControl {
 		}
 		return this.validate_and_set_in_model(value, e);
 	}
-	validate_and_set_in_model(value, e) {
-		var me = this;
-		let force_value_set = (this.doc && this.doc.__run_link_triggers);
-		let is_value_same = (this.get_model_value() === value);
+	validate_and_set_in_model(value, e, force_set_value=false) {
+		const me = this;
+		const is_value_same = (this.get_model_value() === value);
 
-		if (this.inside_change_event || (!force_value_set && is_value_same)) {
+		if (this.inside_change_event || (is_value_same && !force_set_value)) {
 			return Promise.resolve();
 		}
 
diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js
index 57e3f576a1..1459b38df6 100644
--- a/frappe/public/js/frappe/form/form.js
+++ b/frappe/public/js/frappe/form/form.js
@@ -983,7 +983,7 @@ frappe.ui.form.Form = class FrappeForm {
 			$.each(this.fields_dict, function(fieldname, field) {
 				if (field.df.fieldtype=="Link" && this.doc[fieldname]) {
 					// triggers add fetch, sets value in model and runs triggers
-					field.set_value(this.doc[fieldname]);
+					field.set_value(this.doc[fieldname], true);
 				}
 			});