From 7fc4c4a82a609073120f6a78f048d233515ae603 Mon Sep 17 00:00:00 2001
From: shreyas <shreyas@erpnext.com>
Date: Fri, 28 Oct 2016 17:37:14 +0530
Subject: [PATCH] [Minor] Added validation to bulk update in case user does not
 specify value field

---
 .../desk/doctype/bulk_update/bulk_update.js   | 31 +++++++++++--------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/frappe/desk/doctype/bulk_update/bulk_update.js b/frappe/desk/doctype/bulk_update/bulk_update.js
index 8f39ab27a3..cfee158ac7 100644
--- a/frappe/desk/doctype/bulk_update/bulk_update.js
+++ b/frappe/desk/doctype/bulk_update/bulk_update.js
@@ -4,19 +4,24 @@
 frappe.ui.form.on('Bulk Update', {
 	refresh: function(frm) {
 		frm.page.set_primary_action(__('Update'), function() {
-			frappe.call({
-				method: 'frappe.desk.doctype.bulk_update.bulk_update.update',
-				args: {
-					doctype: frm.doc.document_type,
-					field: frm.doc.field,
-					value: frm.doc.update_value,
-					condition: frm.doc.condition,
-					limit: frm.doc.limit
-				},
-				callback: function() {
-					frappe.hide_progress();
-				}
-			});
+			if(!frm.doc.update_value){
+				frappe.throw(__('Field "value" is mandatory. Please specify value to be updated'));
+			}
+			else{
+				frappe.call({
+					method: 'frappe.desk.doctype.bulk_update.bulk_update.update',
+					args: {
+						doctype: frm.doc.document_type,
+						field: frm.doc.field,
+						value: frm.doc.update_value,
+						condition: frm.doc.condition,
+						limit: frm.doc.limit
+					},
+					callback: function() {
+						frappe.hide_progress();
+					}
+				});
+			}
 		});
 	},
 	document_type: function(frm) {