From ca0e4ff60fb07598b63a3d6d6cf8b11a077f5071 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Mon, 1 Aug 2016 15:52:58 +0530 Subject: [PATCH 1/2] [editable-grid] show by template if editable grid is turned-off --- frappe/public/css/form_grid.css | 3 ++ frappe/public/js/frappe/form/grid.js | 42 ++++++++++++++++++++++++---- frappe/public/less/form_grid.less | 4 +++ 3 files changed, 44 insertions(+), 5 deletions(-) diff --git a/frappe/public/css/form_grid.css b/frappe/public/css/form_grid.css index f64ce1bf77..9fe46620be 100644 --- a/frappe/public/css/form_grid.css +++ b/frappe/public/css/form_grid.css @@ -34,6 +34,9 @@ .form-grid .data-row.sortable-handle { cursor: move; } +.form-grid .template-row { + padding: 8px 15px; +} .grid-body .data-row { font-size: 12px; } diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index d78f2ba664..52946250ec 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -37,10 +37,10 @@ frappe.ui.form.Grid = Class.extend({ allow_on_grid_editing: function() { if(frappe.utils.is_xs()) { return false; - } else if(this.editable_fields) { + } else if(this.meta.editable_grid) { return true; } else { - return this.meta.editable_grid; + return false; } }, make: function() { @@ -552,7 +552,11 @@ frappe.ui.form.GridRow = Class.extend({ } }); - this.render_row(); + if(this.grid.template && !this.grid.meta.editable_grid) { + this.render_template(); + } else { + this.render_row(); + } if(this.doc) { this.set_data(); } @@ -600,13 +604,41 @@ frappe.ui.form.GridRow = Class.extend({ } // re write columns this.visible_columns = null; - this.render_row(true); + + if(this.grid.template && !this.grid.meta.editable_grid) { + this.render_template(); + } else { + this.render_row(true); + } // refersh form fields if(this.grid_form) { this.grid_form.layout && this.grid_form.layout.refresh(this.doc); } }, + render_template: function() { + if(this.row_display) { + this.row_display.remove(); + } + var index_html = ''; + + // row index + if(this.doc) { + if(!this.row_index) { + this.row_index = $('
').appendTo(this.row); + } + this.row_index.html(this.doc.idx); + } + + this.row_display = $('
'+ + +'
').appendTo(this.row) + .html(frappe.render(this.grid.template, { + doc: this.doc ? frappe.get_format_helper(this.doc) : null, + frm: this.frm, + row: this + })); + }, render_row: function(refresh) { var me = this; this.set_row_index(); @@ -893,7 +925,7 @@ frappe.ui.form.GridRow = Class.extend({ hide_form: function() { frappe.dom.unfreeze(); this.row.toggle(true); - this.render_row(); + this.refresh(); cur_frm.cur_grid = null; this.wrapper.removeClass("grid-row-open"); }, diff --git a/frappe/public/less/form_grid.less b/frappe/public/less/form_grid.less index 853af71092..2a8d76c313 100644 --- a/frappe/public/less/form_grid.less +++ b/frappe/public/less/form_grid.less @@ -46,6 +46,10 @@ } } +.form-grid .template-row { + padding: 8px 15px; +} + .grid-body .data-row { font-size: 12px; } From 26a6c31bf47e7b1434f7a65baeaee0e002bf783b Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 1 Aug 2016 16:55:25 +0600 Subject: [PATCH 2/2] bumped to version 7.0.12 --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 015efa3cf8..0ef9a02fe2 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -13,7 +13,7 @@ import os, sys, importlib, inspect, json from .exceptions import * from .utils.jinja import get_jenv, get_template, render_template -__version__ = "7.0.11" +__version__ = "7.0.12" local = Local()