diff --git a/frappe/public/css/form.css b/frappe/public/css/form.css index ae34d33a5f..e69253cecc 100644 --- a/frappe/public/css/form.css +++ b/frappe/public/css/form.css @@ -124,3 +124,7 @@ .linked-with-dialog .form-section { padding-top: 15px; } +.attach-missing-image, +.attach-image-display { + cursor: pointer; +} diff --git a/frappe/public/js/frappe/form/control.js b/frappe/public/js/frappe/form/control.js index a1845fd1d5..ecd4380325 100644 --- a/frappe/public/js/frappe/form/control.js +++ b/frappe/public/js/frappe/form/control.js @@ -41,14 +41,12 @@ frappe.ui.form.Control = Class.extend({ // returns "Read", "Write" or "None" // as strings based on permissions get_status: function(explain) { - if(!this.doctype) - return "Write"; - var status = frappe.perm.get_field_display_status(this.df, - locals[this.doctype][this.docname], this.perm || this.frm.perm, explain); + frappe.model.get_doc(this.doctype, this.docname), this.perm || (this.frm && this.frm.perm), explain); // hide if no value - if (status==="Read" && is_null(frappe.model.get_value(this.doctype, this.docname, this.df.fieldname))) { + if (this.doctype && status==="Read" + && is_null(frappe.model.get_value(this.doctype, this.docname, this.df.fieldname))) { status = "None"; } @@ -620,7 +618,7 @@ frappe.ui.form.ControlButton = frappe.ui.form.ControlData.extend({ frappe.ui.form.ControlAttach = frappe.ui.form.ControlData.extend({ make_input: function() { var me = this; - this.$input = $('