From 5ff587fc40adb574a4d03bd1c57e6bd3e88fe414 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Mon, 4 Apr 2022 12:32:08 +0530 Subject: [PATCH] fix(nestedset): Fix rgt value via update_add_node This bug was introduced via https://github.com/frappe/frappe/pull/16468/commits/3358fdf9a99ae9ff57be9ecb4e310f9a1bd105ac --- frappe/utils/nestedset.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frappe/utils/nestedset.py b/frappe/utils/nestedset.py index 1b6bd3e66d..6d81cc1e1c 100644 --- a/frappe/utils/nestedset.py +++ b/frappe/utils/nestedset.py @@ -63,9 +63,8 @@ def update_add_node(doc, parent, parent_field): left, right = frappe.db.get_value(doctype, {"name": parent}, ["lft", "rgt"], for_update=True) validate_loop(doc.doctype, doc.name, left, right) else: # root - right = frappe.qb.from_(Table).select( - Coalesce(Max(Table.rgt), 0) + Coalesce(Max(Table.rgt), 0) + 1 ).where(Coalesce(Table[parent_field], "") == "").run(pluck=True)[0] right = right or 1