From 61b681a1a65dfcde8d98d3a0dca0e159aeb1f951 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 13 Sep 2022 16:32:55 +0530 Subject: [PATCH] fix: create a private workspace if user doesnt have access while duplicating (cherry picked from commit d1abbed18b20771c3948a194e86872d369bd3079) --- .../public/js/frappe/views/workspace/workspace.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/frappe/views/workspace/workspace.js b/frappe/public/js/frappe/views/workspace/workspace.js index f5fdab24ab..5fe982822e 100644 --- a/frappe/public/js/frappe/views/workspace/workspace.js +++ b/frappe/public/js/frappe/views/workspace/workspace.js @@ -794,7 +794,11 @@ frappe.views.Workspace = class Workspace { duplicate_page(page) { var me = this; - let parent_pages = this.get_parent_pages(page); + let new_page = { ...page }; + if (!this.has_access && new_page.public) { + new_page.public = 0; + } + let parent_pages = this.get_parent_pages({ public: new_page.public }); const d = new frappe.ui.Dialog({ title: __("Create Duplicate"), fields: [ @@ -809,14 +813,14 @@ frappe.views.Workspace = class Workspace { fieldtype: "Select", fieldname: "parent", options: parent_pages, - default: page.parent_page, + default: new_page.parent_page, }, { label: __("Public"), fieldtype: "Check", fieldname: "is_public", depends_on: `eval:${this.has_access}`, - default: page.public, + default: new_page.public, onchange: function () { d.set_df_property( "parent", @@ -832,7 +836,7 @@ frappe.views.Workspace = class Workspace { label: __("Icon"), fieldtype: "Icon", fieldname: "icon", - default: page.icon, + default: new_page.icon, }, ], primary_action_label: __("Duplicate"), @@ -854,8 +858,6 @@ frappe.views.Workspace = class Workspace { }, }); - let new_page = { ...page }; - new_page.title = values.title; new_page.public = values.is_public || 0; new_page.name = values.title + (new_page.public ? "" : "-" + frappe.session.user);