From 63ed486bfccafb06e952e5c8ff2c0d6ff4462e1c Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Sat, 17 Jun 2017 13:57:24 +0530 Subject: [PATCH] [hot] fix grid display bug --- frappe/config/desktop.py | 3 ++- frappe/public/js/frappe/form/grid.js | 12 +++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/frappe/config/desktop.py b/frappe/config/desktop.py index 405435c25b..5ac41b59dd 100644 --- a/frappe/config/desktop.py +++ b/frappe/config/desktop.py @@ -68,6 +68,7 @@ def get_data(): "module_name": 'Contacts', "type": 'module', "icon": "octicon octicon-book", - "color": '#FFAEDB' + "color": '#FFAEDB', + "hidden": 1, }, ] diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index 009a781a13..46175124ec 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -1143,11 +1143,13 @@ frappe.ui.form.GridRow = Class.extend({ // format values if no frm if(!df) { - df = this.grid.visible_columns.find((set) => { - return set[0].fieldname === fieldname; - })[0]; - - if(this.doc) var txt = frappe.format(this.doc[fieldname], df, null, this.doc); + df = this.grid.visible_columns.find((col) => { + return col[0].fieldname === fieldname; + }); + if(df && this.doc) { + var txt = frappe.format(this.doc[fieldname], df[0], + null, this.doc); + } } if(txt===undefined && this.frm) {