From 7fa9a3fd39cbc5ecc4db8da50317c3927e302271 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Tue, 25 Jan 2022 12:01:29 +0530 Subject: [PATCH] feat(minor): Add "in list view" fields in sort selector --- frappe/public/js/frappe/ui/sort_selector.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/ui/sort_selector.js b/frappe/public/js/frappe/ui/sort_selector.js index 544467fb14..470f48e0cf 100644 --- a/frappe/public/js/frappe/ui/sort_selector.js +++ b/frappe/public/js/frappe/ui/sort_selector.js @@ -121,9 +121,13 @@ frappe.ui.SortSelector = class SortSelector { _options.push({'fieldname': meta.title_field}); } - // bold or mandatory + // add bold, mandatory and fields that are available in list view meta.fields.forEach(function(df) { - if(df.mandatory || df.bold) { + if ( + (df.mandatory || df.bold || df.in_list_view) + && frappe.model.is_value_type(df.fieldtype) + && frappe.perm.has_perm(me.doctype, df.permlevel, "read") + ) { _options.push({fieldname: df.fieldname, label: df.label}); } });