From 88c8df2350f9cacd3d7128465a034cd5292be2ab Mon Sep 17 00:00:00 2001 From: Saurabh Date: Mon, 3 Jul 2017 12:30:34 +0530 Subject: [PATCH] [minor][fix] check for oauth1 access_key and access_secret before generating dropbox's oauth2 token (#3593) --- .../integrations/doctype/dropbox_settings/dropbox_settings.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frappe/integrations/doctype/dropbox_settings/dropbox_settings.py b/frappe/integrations/doctype/dropbox_settings/dropbox_settings.py index 2fb512e8a0..ed81d663d8 100644 --- a/frappe/integrations/doctype/dropbox_settings/dropbox_settings.py +++ b/frappe/integrations/doctype/dropbox_settings/dropbox_settings.py @@ -272,6 +272,9 @@ def set_dropbox_access_token(access_token): frappe.db.commit() def generate_oauth2_access_token_from_oauth1_token(dropbox_settings=None): + if not dropbox_settings.get("access_key") or not dropbox_settings.get("access_secret"): + return {} + url = "https://api.dropboxapi.com/2/auth/token/from_oauth1" headers = {"Content-Type": "application/json"} auth = (dropbox_settings["app_key"], dropbox_settings["app_secret"])