chore!: remove dead hooks `app_icon` & `app_color`

frappe/hooks.py

@@ -4,8 +4,6 @@ app_name = "frappe"
 app_title = "Frappe Framework"
 app_publisher = "Frappe Technologies"
 app_description = "Full stack web framework with Python, Javascript, MariaDB, Redis, Node"
-app_icon = "octicon octicon-circuit-board"
-app_color = "orange"
 source_link = "https://github.com/frappe/frappe"
 app_license = "MIT"
 app_logo_url = "/assets/frappe/images/frappe-framework-logo.svg"

frappe/tests/test_boilerplate.py

@@ -27,8 +27,6 @@ class TestBoilerPlate(unittest.TestCase):
 				"app_description": "This app's description contains 'single quotes' and \"double quotes\".",
 				"app_publisher": "Test Publisher",
 				"app_email": "example@example.org",
-				"app_icon": "octicon octicon-file-directory",
-				"app_color": "grey",
 				"app_license": "MIT",
 				"create_github_workflow": False,
 			}
@@ -119,8 +117,6 @@ class TestBoilerPlate(unittest.TestCase):
 				"app_description": "This app's description contains 'single quotes' and \"double quotes\".",
 				"app_publisher": "Test Publisher",
 				"app_email": "example@example.org",
-				"app_icon": "octicon octicon-file-directory",
-				"app_color": "grey",
 				"app_license": "MIT",
 			}
 		)
@@ -144,8 +140,6 @@ class TestBoilerPlate(unittest.TestCase):
 				"app_description": "This app's description contains 'single quotes' and \"double quotes\".",
 				"app_publisher": "Test Publisher",
 				"app_email": "example@example.org",
-				"app_icon": "octicon octicon-file-directory",
-				"app_color": "grey",
 				"app_license": "MIT",
 			}
 		)

frappe/utils/boilerplate.py

@@ -40,8 +40,6 @@ def _get_user_inputs(app_name):
 		"app_description": {"prompt": "App Description"},
 		"app_publisher": {"prompt": "App Publisher"},
 		"app_email": {"prompt": "App Email"},
-		"app_icon": {"prompt": "App Icon", "default": "octicon octicon-file-directory"},
-		"app_color": {"prompt": "App Color", "default": "grey"},
 		"app_license": {"prompt": "App License", "default": "MIT"},
 		"create_github_workflow": {
 			"prompt": "Create GitHub Workflow action for unittests",
@@ -197,8 +195,6 @@ app_name = "{app_name}"
 app_title = "{app_title}"
 app_publisher = "{app_publisher}"
 app_description = "{app_description}"
-app_icon = "{app_icon}"
-app_color = "{app_color}"
 app_email = "{app_email}"
 app_license = "{app_license}"
 
@@ -396,8 +392,6 @@ def get_data():
 	return [
 		{{
 			"module_name": "{app_title}",
-			"color": "{app_color}",
-			"icon": "{app_icon}",
 			"type": "module",
 			"label": _("{app_title}")
 		}}

hooks.md

@@ -7,8 +7,6 @@
 1. `app_publisher`
 1. `app_description`
 1. `app_version`
-1. `app_icon` - font-awesome icon or image url
-1. `app_color` - hex colour background of the app icon
 
 #### Install