From 946137717b7946259e0b3c73d5f20d2a37caa093 Mon Sep 17 00:00:00 2001 From: Makarand Bauskar Date: Thu, 5 Oct 2017 15:28:30 +0530 Subject: [PATCH] [hotfix] check if doc has valid title value (#4255) --- frappe/public/js/frappe/form/footer/timeline.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/footer/timeline.js b/frappe/public/js/frappe/form/footer/timeline.js index 03d68a8221..418b8f277e 100644 --- a/frappe/public/js/frappe/form/footer/timeline.js +++ b/frappe/public/js/frappe/form/footer/timeline.js @@ -329,7 +329,8 @@ frappe.ui.form.Timeline = Class.extend({ if(c.subject && c.communication_type==="Communication") { if(this.frm.doc.subject && !this.frm.doc.subject.includes(c.subject)) { c.show_subject = true; - } else if(this.frm.meta.title_field && !!this.frm.doc[this.frm.meta.title_field].includes(c.subject)) { + } else if(this.frm.meta.title_field && this.frm.doc[this.frm.meta.title_field] + && !!this.frm.doc[this.frm.meta.title_field].includes(c.subject)) { c.show_subject = true; } else if(!this.frm.doc.name.includes(c.subject)) { c.show_subject = true;