test: sort folders and files before running tests for consistency (#12689)

* fix: sorted folders list befor adding tests

* fix: sort files as well

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* fix: remove unnecessary cstr

* fix: minor code quality change

* test: use unique `user_email` in `TestAuth`

* test: Use unique username for auth test

* test: Delete DocType Doc A completely after test is done

* test: Fix permission issue & typo in test cases

Co-authored-by: Sagar Vora <sagar@resilient.tech>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>

frappe/core/doctype/user_permission/test_user_permission.py

@@ -18,6 +18,7 @@ class TestUserPermission(unittest.TestCase):
 				'nested_doc_user@example.com')""")
 		frappe.delete_doc_if_exists("DocType", "Person")
 		frappe.db.sql_ddl("DROP TABLE IF EXISTS `tabPerson`")
+		frappe.delete_doc_if_exists("DocType", "Doc A")
 		frappe.db.sql_ddl("DROP TABLE IF EXISTS `tabDoc A`")
 
 	def test_default_user_permission_validation(self):
@@ -221,7 +222,7 @@ class TestUserPermission(unittest.TestCase):
 
 		# User default Doctype value is ToDo via Session Defaults
 		frappe.set_user("user_default_test@example.com")
-		set_session_default_values({"doctype": "ToDo"})
+		set_session_default_values({"doc": "ToDo"})
 
 		new_doc = frappe.new_doc("Doc A")
 

frappe/core/doctype/version/test_version.py

@@ -9,6 +9,7 @@ from frappe.core.doctype.version.version import get_diff
 
 class TestVersion(unittest.TestCase):
 	def test_get_diff(self):
+		frappe.set_user('Administrator')
 		test_records = make_test_objects('Event', reset = True)
 		old_doc = frappe.get_doc("Event", test_records[0])
 		new_doc = copy.deepcopy(old_doc)

frappe/test_runner.py

@@ -117,13 +117,16 @@ def run_all_tests(app=None, verbose=False, profile=False, ui_tests=False, failfa
 	test_suite = unittest.TestSuite()
 	for app in apps:
 		for path, folders, files in os.walk(frappe.get_pymodule_path(app)):
-			for dontwalk in ('locals', '.git', 'public'):
+			for dontwalk in ('locals', '.git', 'public', '__pycache__'):
 				if dontwalk in folders:
 					folders.remove(dontwalk)
 
+			# for predictability
+			folders.sort()
+			files.sort()
+
 			# print path
 			for filename in files:
-				filename = cstr(filename)
 				if filename.startswith("test_") and filename.endswith(".py")\
 					and filename != 'test_runner.py':
 					# print filename[:-3]

frappe/tests/test_auth.py

@@ -12,8 +12,8 @@ from frappe.frappeclient import FrappeClient, AuthError
 class TestAuth(unittest.TestCase):
 	def __init__(self, *args, **kwargs):
 		super(TestAuth, self).__init__(*args, **kwargs)
-		self.test_user_email = 'test@test.com'
-		self.test_user_name = 'test_user'
+		self.test_user_email = 'test_auth@test.com'
+		self.test_user_name = 'test_auth_user'
 		self.test_user_mobile = '+911234567890'
 		self.test_user_password = 'pwd_012'