From a5d576f82c57cbce1fac009041aa5910303dc198 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Tue, 2 Aug 2022 15:10:53 +0530 Subject: [PATCH] fix(global_search): Trigger rebuilding on Custom Field's property change (#17706) (cherry picked from commit 3863d9bb803d92b49f01095071719991d95d9a86) Co-authored-by: Gavin D'souza --- frappe/custom/doctype/customize_form/customize_form.py | 5 +++++ frappe/utils/global_search.py | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/frappe/custom/doctype/customize_form/customize_form.py b/frappe/custom/doctype/customize_form/customize_form.py index 4923bfc525..dc625d1a58 100644 --- a/frappe/custom/doctype/customize_form/customize_form.py +++ b/frappe/custom/doctype/customize_form/customize_form.py @@ -374,6 +374,9 @@ class CustomizeForm(Document): d.insert() df.fieldname = d.fieldname + if df.get("in_global_search"): + self.flags.rebuild_doctype_for_global_search = True + def update_in_custom_field(self, df, i): meta = frappe.get_meta(self.doc_type) meta_df = meta.get("fields", {"fieldname": df.fieldname}) @@ -387,6 +390,8 @@ class CustomizeForm(Document): if df.get(prop) != custom_field.get(prop): if prop == "fieldtype": self.validate_fieldtype_change(df, meta_df[0].get(prop), df.get(prop)) + if prop == "in_global_search": + self.flags.rebuild_doctype_for_global_search = True custom_field.set(prop, df.get(prop)) changed = True diff --git a/frappe/utils/global_search.py b/frappe/utils/global_search.py index 14dcc0fdda..ba22251f6c 100644 --- a/frappe/utils/global_search.py +++ b/frappe/utils/global_search.py @@ -73,9 +73,6 @@ def rebuild_for_doctype(doctype): if frappe.local.conf.get("disable_global_search"): return - if frappe.local.conf.get("disable_global_search"): - return - def _get_filters(): filters = frappe._dict({"docstatus": ["!=", 2]}) if meta.has_field("enabled"):