From fee697e7f3728d54ff8b00a787912dc1702b84ca Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Fri, 7 Jul 2017 20:19:53 +0530 Subject: [PATCH 1/3] [fix] summernote recursion --- frappe/public/js/frappe/form/control.js | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/frappe/public/js/frappe/form/control.js b/frappe/public/js/frappe/form/control.js index bd4e876165..cc7c4f35e9 100755 --- a/frappe/public/js/frappe/form/control.js +++ b/frappe/public/js/frappe/form/control.js @@ -282,7 +282,6 @@ frappe.ui.form.ControlInput = frappe.ui.form.Control.extend({ // mandatory style on refresh refresh_input: function() { var me = this; - var make_input = function() { if(!me.has_input) { me.make_input(); @@ -1724,6 +1723,7 @@ frappe.ui.form.ControlTextEditor = frappe.ui.form.ControlCode.extend({ }); }, onChange: function(value) { + if(this._setting_value) return; me.parse_validate_and_set_in_model(value); }, onKeydown: function(e) { @@ -1847,18 +1847,23 @@ frappe.ui.form.ControlTextEditor = frappe.ui.form.ControlCode.extend({ }, set_in_editor: function(value) { // set value after user has stopped editing + if(this.__setting_value) { + // we don't understand how the internal triggers work, + // so quit + return; + } + if(!this._last_change_on || (moment() - moment(this._last_change_on) > 3000)) { + this.__setting_value = setTimeout(() => this.__setting_value = null, 500); this.editor.summernote('code', value); } else { - if(!this._setting_value) { - this._setting_value = setInterval(() => { - if(moment() - moment(this._last_change_on) > 3000) { - this.editor.summernote('code', this.last_value); - clearInterval(this._setting_value); - this._setting_value = null; - } - }, 1000); - } + this._setting_value = setInterval(() => { + if(moment() - moment(this._last_change_on) > 3000) { + this.editor.summernote('code', this.last_value); + clearInterval(this._setting_value); + this._setting_value = null; + } + }, 1000); } }, set_focus: function() { From b89c69ee60adb0ca1806d0919f4aa8d87e5a36c8 Mon Sep 17 00:00:00 2001 From: Makarand Bauskar Date: Fri, 7 Jul 2017 20:29:31 +0530 Subject: [PATCH 2/3] [hotfix] uncaught read property split of undefinded (#3640) --- frappe/public/js/frappe/ui/filters/filters.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/filters/filters.js b/frappe/public/js/frappe/ui/filters/filters.js index 55c07fc4ac..256acd278d 100644 --- a/frappe/public/js/frappe/ui/filters/filters.js +++ b/frappe/public/js/frappe/ui/filters/filters.js @@ -408,7 +408,9 @@ frappe.ui.Filter = Class.extend({ } } } else if(in_list(["in", "not in"], this.get_condition())) { - val = $.map(val.split(","), function(v) { return strip(v); }); + if(val) { + val = $.map(val.split(","), function(v) { return strip(v); }); + } } if(val === '%') { val = ""; } From a2090da413b6cdeefa3cec03cf939b3fa2bd7349 Mon Sep 17 00:00:00 2001 From: mbauskar Date: Fri, 7 Jul 2017 21:00:07 +0600 Subject: [PATCH 3/3] bumped to version 8.3.6 --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 3bcb3a6705..e17a925e46 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -14,7 +14,7 @@ import os, sys, importlib, inspect, json from .exceptions import * from .utils.jinja import get_jenv, get_template, render_template -__version__ = '8.3.5' +__version__ = '8.3.6' __title__ = "Frappe Framework" local = Local()