build: reliable asset building in production (backport #18133) (#18136)

* build: move all devDependencies to Dependencies

These are real dependencies without which you can't locally build apps.

(cherry picked from commit 06aaaaaedf)

* fix: fail code when build fails in production

In production it is useful to fail with proper exit code. To avoid
silently pushing bad assets in built pipelines.

(cherry picked from commit 1ba99396bc)

Co-authored-by: Ankush Menat <ankush@frappe.io>

esbuild/esbuild.js

@@ -103,7 +103,7 @@ async function execute() {
 		log_error("There were some problems during build");
 		log();
 		log(chalk.dim(e.stack));
-		if (process.env.CI) {
+		if (process.env.CI || PRODUCTION) {
 			process.kill(process.pid);
 		}
 		return;

package.json

@@ -61,9 +61,7 @@
     "vue": "2.6.14",
     "vue-router": "^2.0.0",
     "vuedraggable": "^2.24.3",
-    "vuex": "3"
-  },
-  "devDependencies": {
+    "vuex": "3",
     "@frappe/esbuild-plugin-postcss2": "^0.1.3",
     "@vue/component-compiler": "^4.2.4",
     "autoprefixer": "10",