Bladeren bron

fix(rate-limiter): Remove duplicate headers

version-14
Aditya Hase 5 jaren geleden
bovenliggende
commit
aef567fdde
2 gewijzigde bestanden met toevoegingen van 11 en 9 verwijderingen
  1. +1
    -1
      frappe/rate_limiter.py
  2. +10
    -8
      frappe/tests/test_rate_limiter.py

+ 1
- 1
frappe/rate_limiter.py Bestand weergeven

@@ -78,4 +78,4 @@ class RateLimiter:

def respond(self):
if self.rejected:
return Response(_("Too Many Requests"), status=429, headers=self.headers())
return Response(_("Too Many Requests"), status=429)

+ 10
- 8
frappe/tests/test_rate_limiter.py Bestand weergeven

@@ -46,14 +46,16 @@ class TestRateLimiter(unittest.TestCase):

self.assertIsInstance(response, Response)
self.assertEqual(response.status_code, 429)
self.assertIn("Retry-After", response.headers)
self.assertNotIn("X-RateLimit-Used", response.headers)
self.assertIn("X-RateLimit-Reset", response.headers)
self.assertIn("X-RateLimit-Limit", response.headers)
self.assertIn("X-RateLimit-Remaining", response.headers)
self.assertTrue(int(response.headers["X-RateLimit-Reset"]) <= 86400)
self.assertEqual(int(response.headers["X-RateLimit-Limit"]), 10000)
self.assertEqual(int(response.headers["X-RateLimit-Remaining"]), 0)

headers = frappe.local.rate_limiter.headers()
self.assertIn("Retry-After", headers)
self.assertNotIn("X-RateLimit-Used", headers)
self.assertIn("X-RateLimit-Reset", headers)
self.assertIn("X-RateLimit-Limit", headers)
self.assertIn("X-RateLimit-Remaining", headers)
self.assertTrue(int(headers["X-RateLimit-Reset"]) <= 86400)
self.assertEqual(int(headers["X-RateLimit-Limit"]), 10000)
self.assertEqual(int(headers["X-RateLimit-Remaining"]), 0)

frappe.cache().delete(limiter.key)
frappe.cache().delete(frappe.local.rate_limiter.key)


Laden…
Annuleren
Opslaan