From afc060f1eb9edaf6d6d66aad3f8163eae72dfbe4 Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Mon, 8 Aug 2022 18:38:43 +0530
Subject: [PATCH] fix: ignore forms without docs in realtime events

(cherry picked from commit b263d7a724dbc3a4f811aed35f91bdcd5dabed13)
---
 frappe/public/js/frappe/socketio_client.js | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/frappe/public/js/frappe/socketio_client.js b/frappe/public/js/frappe/socketio_client.js
index 9eeae3c916..6d01c19d42 100644
--- a/frappe/public/js/frappe/socketio_client.js
+++ b/frappe/public/js/frappe/socketio_client.js
@@ -59,7 +59,7 @@ frappe.socketio = {
 		frappe.socketio.setup_reconnect();
 
 		$(document).on("form-load form-rename", function (e, frm) {
-			if (frm.is_new()) {
+			if (!frm.doc || frm.is_new()) {
 				return;
 			}
 
@@ -75,7 +75,7 @@ frappe.socketio = {
 		});
 
 		$(document).on("form-refresh", function (e, frm) {
-			if (frm.is_new()) {
+			if (!frm.doc || frm.is_new()) {
 				return;
 			}
 
@@ -83,7 +83,7 @@ frappe.socketio = {
 		});
 
 		$(document).on("form-unload", function (e, frm) {
-			if (frm.is_new()) {
+			if (!frm.doc || frm.is_new()) {
 				return;
 			}
 
@@ -100,14 +100,11 @@ frappe.socketio = {
 		});
 
 		window.addEventListener("beforeunload", () => {
-			if (!cur_frm || cur_frm.is_new()) {
+			if (!cur_frm || !cur_frm.doc || cur_frm.is_new()) {
 				return;
 			}
 
-			// if tab/window is closed, notify other users
-			if (cur_frm.doc) {
-				frappe.socketio.doc_close(cur_frm.doctype, cur_frm.docname);
-			}
+			frappe.socketio.doc_close(cur_frm.doctype, cur_frm.docname);
 		});
 	},
 	get_host: function (port = 3000) {