Browse Source

[fixes] [minor] email and doctype message

version-14
Rushabh Mehta 10 years ago
parent
commit
b05a6ef9b0
2 changed files with 10 additions and 11 deletions
  1. +2
    -9
      frappe/email/doctype/email_account/email_account.py
  2. +8
    -2
      frappe/model/db_schema.py

+ 2
- 9
frappe/email/doctype/email_account/email_account.py View File

@@ -190,15 +190,8 @@ class EmailAccount(Document):
parent = frappe.get_doc("Communication", in_reply_to) parent = frappe.get_doc("Communication", in_reply_to)


if parent.reference_name: if parent.reference_name:
if self.append_to:
# parent must reference only if name matches
if parent.reference_doctype==self.append_to:
# parent same as parent of last communication
parent = frappe.get_doc(parent.reference_doctype,
parent.reference_name)
else:
parent = frappe.get_doc(parent.reference_doctype,
parent.reference_name)
parent = frappe.get_doc(parent.reference_doctype,
parent.reference_name)


if not parent and self.append_to and sender_field: if not parent and self.append_to and sender_field:
if subject_field: if subject_field:


+ 8
- 2
frappe/model/db_schema.py View File

@@ -234,7 +234,14 @@ class DbTable:
query.append('alter column `{}` set default {}'.format(col.fieldname, col_default)) query.append('alter column `{}` set default {}'.format(col.fieldname, col_default))


if query: if query:
frappe.db.sql("alter table `{}` {}".format(self.name, ", ".join(query)))
try:
frappe.db.sql("alter table `{}` {}".format(self.name, ", ".join(query)))
except Exception, e:
# sanitize
if e.args[0]==1060:
frappe.throw(str(e))
else:
raise e


class DbColumn: class DbColumn:
def __init__(self, table, fieldname, fieldtype, length, default, def __init__(self, table, fieldname, fieldtype, length, default,
@@ -469,4 +476,3 @@ def add_column(doctype, column_name, fieldtype, precision=None):
frappe.db.commit() frappe.db.commit()
frappe.db.sql("alter table `tab%s` add column %s %s" % (doctype, frappe.db.sql("alter table `tab%s` add column %s %s" % (doctype,
column_name, get_definition(fieldtype, precision))) column_name, get_definition(fieldtype, precision)))


Loading…
Cancel
Save