From dd731903bde7b7116efcfb23f9c9c09489749027 Mon Sep 17 00:00:00 2001 From: karthikeyan5 Date: Fri, 24 Dec 2021 10:04:42 +0530 Subject: [PATCH 1/2] fix(print page): addtional menu in mobile view --- frappe/printing/page/print/print.js | 2 +- frappe/public/js/frappe/ui/page.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/printing/page/print/print.js b/frappe/printing/page/print/print.js index f10c703589..7a87d0fce2 100644 --- a/frappe/printing/page/print/print.js +++ b/frappe/printing/page/print/print.js @@ -52,8 +52,8 @@ frappe.ui.form.PrintView = class { ':Print Settings', 'Print Settings' ); - this.setup_toolbar(); this.setup_menu(); + this.setup_toolbar(); this.setup_sidebar(); this.setup_keyboard_shortcuts(); } diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js index c299edb7db..91a2390cdb 100644 --- a/frappe/public/js/frappe/ui/page.js +++ b/frappe/public/js/frappe/ui/page.js @@ -714,6 +714,10 @@ frappe.ui.Page = class Page { ${opts.icon ? frappe.utils.icon(opts.icon): ''} ${label} `); + // Add actions as menu item in Mobile View (similar to "add_custom_button" in forms.js) + let menu_item = this.add_menu_item(label, click, false); + menu_item.parent().addClass("hidden-xl"); + button.appendTo(this.custom_actions); button.on('click', click); this.custom_actions.removeClass('hide'); From a1c9282368baf820f8551d5bd8fc45c79bddd031 Mon Sep 17 00:00:00 2001 From: karthikeyan5 Date: Fri, 24 Dec 2021 20:35:17 +0530 Subject: [PATCH 2/2] fix: update refresh lable in print view --- frappe/printing/page/print/print.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/printing/page/print/print.js b/frappe/printing/page/print/print.js index 7a87d0fce2..5d04fbe982 100644 --- a/frappe/printing/page/print/print.js +++ b/frappe/printing/page/print/print.js @@ -81,8 +81,9 @@ frappe.ui.form.PrintView = class { ); this.page.add_button( - frappe.utils.icon('refresh'), - () => this.refresh_print_format() + __('Refresh'), + () => this.refresh_print_format(), + { icon: 'refresh' } ); }