From b6cb0fc1e7e66fb22c2324756b5535f54332065e Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Mon, 17 Jan 2022 10:01:29 +0530 Subject: [PATCH] fix: Pass SQL string of lastupdate instead of normal string - Normal string of pypika field has additional quotes which creates a invalid query - `get_sql` returns column name without additional quotes --- frappe/sessions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/sessions.py b/frappe/sessions.py index 6c9acdba13..d2d1a8fcbc 100644 --- a/frappe/sessions.py +++ b/frappe/sessions.py @@ -112,7 +112,7 @@ def get_expired_sessions(): frappe.db.get_values( sessions, filters=( - PseudoColumn(f"({Now() - sessions.lastupdate})") + PseudoColumn(f"({Now()} - {sessions.lastupdate.get_sql()})") > get_expiry_period_for_query(device) ) & (sessions.device == device), @@ -334,7 +334,7 @@ class Session: sessions, filters=(sessions.sid == self.sid) & ( - PseudoColumn(f"({Now() - sessions.lastupdate})") + PseudoColumn(f"({Now()} - {sessions.lastupdate.get_sql()})") < get_expiry_period_for_query(self.device) ), fieldname=["user", "sessiondata"],