From bbf5ad1ea7d859a4953ed8766f595801031fc6b2 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Thu, 6 Apr 2017 11:15:50 +0530 Subject: [PATCH] Remove render_item, fix post_render_item --- frappe/public/js/frappe/list/list_renderer.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/frappe/public/js/frappe/list/list_renderer.js b/frappe/public/js/frappe/list/list_renderer.js index 189c0d6a44..5e9399cab0 100644 --- a/frappe/public/js/frappe/list/list_renderer.js +++ b/frappe/public/js/frappe/list/list_renderer.js @@ -317,21 +317,17 @@ frappe.views.ListRenderer = Class.extend({ const $item_container = $('
').append($item); $list_items.append($item_container); - this.render_item($item_container, value); + + if (this.settings.post_render_item) { + this.settings.post_render_item(this, $item_container, value); + } + + this.render_tags($item_container, value); }); this.setup_filterable(); }, - // renders data(doc) in element - render_item: function (element, data) { - if (this.settings.post_render_item) { - this.settings.post_render_item(this, element, data); - } - - this.render_tags(element, data); - }, - // returns html for a data item, // usually based on a template get_item_html: function (data) {