Pārlūkot izejas kodu

revert: server script errors (#15758)

#15334 added a change where all exceptions are caught when a server
script is executed, which makes validation errors useless. reverting this
for now, until we find a better solution.
version-14
Faris Ansari pirms 3 gadiem
committed by GitHub
vecāks
revīzija
be41896d60
Šim parakstam datu bāzē netika atrasta zināma atslēga GPG atslēgas ID: 4AEE18F83AFDEB23
1 mainītis faili ar 1 papildinājumiem un 13 dzēšanām
  1. +1
    -13
      frappe/core/doctype/server_script/server_script_utils.py

+ 1
- 13
frappe/core/doctype/server_script/server_script_utils.py Parādīt failu

@@ -34,19 +34,7 @@ def run_server_script_for_doc_event(doc, event):
if scripts: if scripts:
# run all scripts for this doctype + event # run all scripts for this doctype + event
for script_name in scripts: for script_name in scripts:
try:
frappe.get_doc('Server Script', script_name).execute_doc(doc)
except Exception as e:
message = frappe._('Error executing Server Script {0}. Open Browser Console to see traceback.').format(
frappe.utils.get_link_to_form('Server Script', script_name)
)
exception = type(e)
if getattr(frappe, 'request', None):
# all exceptions throw 500 which is internal server error
# however server script error is a user error
# so we should throw 417 which is expectation failed
exception.http_status_code = 417
frappe.throw(title=frappe._('Server Script Error'), msg=message, exc=exception)
frappe.get_doc('Server Script', script_name).execute_doc(doc)


def get_server_script_map(): def get_server_script_map():
# fetch cached server script methods # fetch cached server script methods


Notiek ielāde…
Atcelt
Saglabāt