From bee15006cb1f8945fc3254a773def07ef1fcb6f7 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Sat, 9 Feb 2019 20:51:39 +0530 Subject: [PATCH] fix: string formatting --- frappe/core/doctype/comment/comment.py | 4 ++-- frappe/templates/includes/comments/comments.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/core/doctype/comment/comment.py b/frappe/core/doctype/comment/comment.py index dd2d8e53e2..e7b495a863 100644 --- a/frappe/core/doctype/comment/comment.py +++ b/frappe/core/doctype/comment/comment.py @@ -149,8 +149,8 @@ def update_comments_in_parent(reference_doctype, reference_name, _comments): try: # use sql, so that we do not mess with the timestamp - frappe.db.sql("""update `tab%s` set `_comments`=%s where name=%s""" % (reference_doctype, - "%s", "%s"), (json.dumps(_comments), reference_name)) + frappe.db.sql("""update `tab{0}` set `_comments`=%s where name=%s""".format(reference_doctype), + (json.dumps(_comments), reference_name)) except Exception as e: if frappe.db.is_column_missing(e) and getattr(frappe.local, 'request', None): diff --git a/frappe/templates/includes/comments/comments.py b/frappe/templates/includes/comments/comments.py index e73ac3fd1a..8dd5039e36 100644 --- a/frappe/templates/includes/comments/comments.py +++ b/frappe/templates/includes/comments/comments.py @@ -30,7 +30,7 @@ def add_comment(comment, comment_email, comment_by, reference_doctype, reference content = (doc.content + "

{2}

".format(frappe.utils.get_request_site_address(), doc.name, - route, _("View Comment"))) + _("View Comment"))) # notify creator frappe.sendmail(