diff --git a/frappe/realtime.py b/frappe/realtime.py index 79190b8bb8..f546703e58 100644 --- a/frappe/realtime.py +++ b/frappe/realtime.py @@ -169,14 +169,16 @@ def get_task_log_file_path(task_id, stream_type): @frappe.whitelist(allow_guest=True) -def can_subscribe_doc(doctype, docname, sid): +def can_subscribe_doc(doctype, docname): if os.environ.get('CI'): return True + from frappe.sessions import Session from frappe.exceptions import PermissionError session = Session(None, resume=True).get_session_data() if not frappe.has_permission(user=session.user, doctype=doctype, doc=docname, ptype='read'): raise PermissionError() + return True @frappe.whitelist(allow_guest=True) diff --git a/socketio.js b/socketio.js index b3577d8a6b..136787858a 100644 --- a/socketio.js +++ b/socketio.js @@ -142,10 +142,10 @@ io.on('connection', function (socket) { socket.on('doc_open', function (doctype, docname) { can_subscribe_doc({ - socket: socket, - sid: sid, - doctype: doctype, - docname: docname, + socket, + sid, + doctype, + docname, callback: () => { var room = get_open_doc_room(socket, doctype, docname); socket.join(room);