diff --git a/webnotes/__init__.py b/webnotes/__init__.py index cfd82cee66..677e9be363 100644 --- a/webnotes/__init__.py +++ b/webnotes/__init__.py @@ -252,10 +252,10 @@ def whitelist(allow_guest=False): def only_for(roles): if not isinstance(roles, (tuple, list)): roles = (roles,) - myroles = get_roles() - for role in roles: - if role not in myroles: - raise PermissionError + roles = set(roles) + myroles = set(get_roles()) + if not roles.intersection(myroles): + raise PermissionError class HashAuthenticatedCommand(object): def __init__(self):