From c9b367933a3de7e587acd12060a6da53cce4de3f Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Mon, 29 Mar 2021 23:16:33 +0530 Subject: [PATCH] fix(minor): make group_by validation tighter --- frappe/model/db_query.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/model/db_query.py b/frappe/model/db_query.py index 924686299a..2d553335ee 100644 --- a/frappe/model/db_query.py +++ b/frappe/model/db_query.py @@ -745,7 +745,7 @@ class DatabaseQuery(object): return _lower = parameters.lower() - if 'select' in _lower and ' from ' in _lower: + if 'select' in _lower and 'from' in _lower: frappe.throw(_('Cannot use sub-query in order by')) if re.compile(r".*[^a-z0-9-_ ,`'\"\.\(\)].*").match(_lower):