From cb5252608d4642258cfc826cdb4887914728a5d3 Mon Sep 17 00:00:00 2001 From: Kanchan Chauhan Date: Sun, 24 Jul 2016 00:30:41 +0530 Subject: [PATCH] Logout issue on not providing password fixed for Email Account --- frappe/email/doctype/email_account/email_account.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/frappe/email/doctype/email_account/email_account.py b/frappe/email/doctype/email_account/email_account.py index 4c71c31dcf..845e82c315 100755 --- a/frappe/email/doctype/email_account/email_account.py +++ b/frappe/email/doctype/email_account/email_account.py @@ -93,6 +93,8 @@ class EmailAccount(Document): if self.enable_outgoing: if not self.smtp_server: frappe.throw(_("{0} is required").format("SMTP Server")) + if not self.password: + frappe.throw(_("{0} is required").format("Password")) server = SMTPServer(login = getattr(self, "login_id", None) \ or self.email_id, @@ -105,6 +107,9 @@ class EmailAccount(Document): def get_server(self, in_receive=False): """Returns logged in POP3 connection object.""" + if not self.password: + frappe.throw(_("{0} is required").format("Password")) + args = { "host": self.email_server, "use_ssl": self.use_ssl,