From cc03176f50bfe023a4468da26d682928d3e237b6 Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Sun, 14 Aug 2022 13:42:24 +0530
Subject: [PATCH] ci: disable coverge on stable branch

Coverage has ~30% overhead, not required on stable branch
---
 .github/helper/install.sh                   |  3 --
 .github/workflows/server-mariadb-tests.yml  | 12 +------
 .github/workflows/server-postgres-tests.yml | 12 +------
 .github/workflows/ui-tests.yml              | 36 ++-------------------
 4 files changed, 4 insertions(+), 59 deletions(-)

diff --git a/.github/helper/install.sh b/.github/helper/install.sh
index 1a2c62c973..3468917cc9 100644
--- a/.github/helper/install.sh
+++ b/.github/helper/install.sh
@@ -52,9 +52,6 @@ if [ "$TYPE" == "server" ]; then
   sed -i 's/^socketio:/# socketio:/g' Procfile;
   sed -i 's/^redis_socketio:/# redis_socketio:/g' Procfile;
 fi
-if [ "$TYPE" == "ui" ]; then
-  sed -i 's/^web: bench serve/web: bench serve --with-coverage/g' Procfile;
-fi
 
 echo "Starting Bench..."
 
diff --git a/.github/workflows/server-mariadb-tests.yml b/.github/workflows/server-mariadb-tests.yml
index c8ccfa7862..6f2d9dc7ef 100644
--- a/.github/workflows/server-mariadb-tests.yml
+++ b/.github/workflows/server-mariadb-tests.yml
@@ -122,17 +122,7 @@ jobs:
 
       - name: Run Tests
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
-        run: cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --use-orchestrator --with-coverage
+        run: cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --use-orchestrator
         env:
           CI_BUILD_ID: ${{ github.run_id }}
           ORCHESTRATOR_URL: http://test-orchestrator.frappe.io
-
-      - name: Upload coverage data
-        if: ${{ steps.check-build.outputs.build == 'strawberry' }}
-        uses: codecov/codecov-action@v3
-        with:
-          name: MariaDB
-          fail_ci_if_error: true
-          files: /home/runner/frappe-bench/sites/coverage.xml
-          verbose: true
-          flags: server
diff --git a/.github/workflows/server-postgres-tests.yml b/.github/workflows/server-postgres-tests.yml
index 9760067197..659fd00472 100644
--- a/.github/workflows/server-postgres-tests.yml
+++ b/.github/workflows/server-postgres-tests.yml
@@ -125,17 +125,7 @@ jobs:
 
       - name: Run Tests
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
-        run: cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --use-orchestrator --with-coverage
+        run: cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --use-orchestrator
         env:
           CI_BUILD_ID: ${{ github.run_id }}
           ORCHESTRATOR_URL: http://test-orchestrator.frappe.io
-
-      - name: Upload coverage data
-        if: ${{ steps.check-build.outputs.build == 'strawberry' }}
-        uses: codecov/codecov-action@v3
-        with:
-          name: Postgres
-          fail_ci_if_error: true
-          files: /home/runner/frappe-bench/sites/coverage.xml
-          verbose: true
-          flags: server
diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml
index 115b8c2b1b..f6293db18f 100644
--- a/.github/workflows/ui-tests.yml
+++ b/.github/workflows/ui-tests.yml
@@ -144,42 +144,10 @@ jobs:
 
       - name: UI Tests
         if: ${{ steps.check-build.outputs.build == 'strawberry' }}
-        run: cd ~/frappe-bench/ && bench --site test_site run-ui-tests frappe --with-coverage --headless --parallel --ci-build-id $GITHUB_RUN_ID-$GITHUB_RUN_ATTEMPT
+        run: cd ~/frappe-bench/ && bench --site test_site run-ui-tests frappe --headless --parallel --ci-build-id $GITHUB_RUN_ID-$GITHUB_RUN_ATTEMPT
         env:
           CYPRESS_RECORD_KEY: 4a48f41c-11b3-425b-aa88-c58048fa69eb
 
-      - name: Stop server
-        if: ${{ steps.check-build.outputs.build-server == 'strawberry' }}
-        run: |
-          ps -ef | grep "frappe serve" | awk '{print $2}' | xargs kill -s SIGINT 2> /dev/null || true
-          sleep 5
-
-      - name: Check If Coverage Report Exists
-        id: check_coverage
-        uses: andstor/file-existence-action@v1
-        with:
-          files: "/home/runner/frappe-bench/apps/frappe/.cypress-coverage/clover.xml"
-
-      - name: Upload Coverage Data
-        if: ${{ steps.check-build.outputs.build == 'strawberry' && steps.check_coverage.outputs.files_exists == 'true' }}
-        uses: codecov/codecov-action@v3
-        with:
-          name: Cypress
-          fail_ci_if_error: true
-          directory: /home/runner/frappe-bench/apps/frappe/.cypress-coverage/
-          verbose: true
-          flags: ui-tests
-
-      - name: Upload Server Coverage Data
-        if: ${{ steps.check-build.outputs.build-server == 'strawberry' }}
-        uses: codecov/codecov-action@v3
-        with:
-          name: MariaDB
-          fail_ci_if_error: true
-          files: /home/runner/frappe-bench/sites/coverage.xml
-          verbose: true
-          flags: server
-
       - name: Show bench console if tests failed
         if: ${{ failure() }}
-        run: cat ~/frappe-bench/bench_start.log
\ No newline at end of file
+        run: cat ~/frappe-bench/bench_start.log