From cf4060d632253bc0cd69f8e701c95aaf4dfd93df Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Thu, 18 Jan 2018 15:37:28 +0530 Subject: [PATCH] [Fix] Feedback issue (#4867) --- frappe/core/doctype/feedback_trigger/feedback_trigger.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/feedback_trigger/feedback_trigger.py b/frappe/core/doctype/feedback_trigger/feedback_trigger.py index e40f668d58..e2265913ad 100644 --- a/frappe/core/doctype/feedback_trigger/feedback_trigger.py +++ b/frappe/core/doctype/feedback_trigger/feedback_trigger.py @@ -116,7 +116,8 @@ def get_feedback_request_details(reference_doctype, reference_name, trigger="Man frappe.msgprint(_("At least one reply is mandatory before requesting feedback")) return None - if recipients and frappe.safe_eval(feedback_trigger.condition, None, context): + if recipients and (not feedback_trigger.condition or \ + frappe.safe_eval(feedback_trigger.condition, None, context)): subject = feedback_trigger.subject context.update({ "feedback_trigger": feedback_trigger })